Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 785053002: [WIP] Screen Orientation OOIF (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)
Modified:
3 years, 5 months ago
Reviewers:
kenrb
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, dcheng, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[WIP] Screen Orientation OOIF BUG=<TODO>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mlamouri (slow - plz ping)
Ken, could you have a look at this WIP CL. I'm trying to see how ...
6 years ago (2014-12-08 21:56:27 UTC) #2
(Do not use) creis at google
[Just +site-isolation-reviews@chromium.org for FYI]
6 years ago (2014-12-08 23:20:59 UTC) #3
kenrb
Yes, each RenderWidget should get a resize event. I have a couple of concerns about ...
6 years ago (2014-12-09 04:27:03 UTC) #4
mlamouri (slow - plz ping)
On 2014/12/09 04:27:03, kenrb wrote: > The other thing is that it looks like right ...
6 years ago (2014-12-09 12:16:48 UTC) #5
kenrb
6 years ago (2014-12-09 14:44:02 UTC) #6
Ok, that makes sense.

This won't work yet, but I think the right way to do this will be something like
putting this line in render_widget.cc:
if (webwidget_->isWebFrameWidget())
    toWebFrameWidget(webwidget_)->localRoot()->sendOrientationChangeEvent();

It seems like the ScreenOrientationController should take care of subframe
traversal from there?

WebFrameWidget is not landed yet, and also doesn't yet have a localRoot accessor
but I think adding one would make sense.

See: https://codereview.chromium.org/638003004/

Powered by Google App Engine
This is Rietveld 408576698