Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: voice_engine/channel.h

Issue 3019513002: Remove the VoiceEngineObserver callback interface. (Closed)
Patch Set: rebase + build error Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « voice_engine/BUILD.gn ('k') | voice_engine/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: voice_engine/channel.h
diff --git a/voice_engine/channel.h b/voice_engine/channel.h
index 53b8cd0ce394c51fb1846e7ba2c6ffd9189e4fe2..8c163657ec90cf04ea4ed56cfffad056df0e1673 100644
--- a/voice_engine/channel.h
+++ b/voice_engine/channel.h
@@ -55,7 +55,6 @@ class RtpPacketReceived;
class RtpRtcp;
class RtpTransportControllerSendInterface;
class TelephoneEventHandler;
-class VoiceEngineObserver;
struct SenderInfo;
@@ -161,7 +160,6 @@ class Channel
int32_t SetEngineInformation(Statistics& engineStatistics,
ProcessThread& moduleProcessThread,
AudioDeviceModule& audioDeviceModule,
- VoiceEngineObserver* voiceEngineObserver,
rtc::CriticalSection* callbackCritSect,
rtc::TaskQueue* encoder_queue);
@@ -187,8 +185,6 @@ class Channel
int32_t StopPlayout();
int32_t StartSend();
void StopSend();
- int32_t RegisterVoiceEngineObserver(VoiceEngineObserver& observer);
- int32_t DeRegisterVoiceEngineObserver();
// Codecs
int32_t GetSendCodec(CodecInst& codec);
@@ -427,7 +423,6 @@ class Channel
Statistics* _engineStatisticsPtr;
ProcessThread* _moduleProcessThreadPtr;
AudioDeviceModule* _audioDeviceModulePtr;
- VoiceEngineObserver* _voiceEngineObserverPtr; // owned by base
rtc::CriticalSection* _callbackCritSectPtr; // owned by base
Transport* _transportPtr; // WebRtc socket or external transport
RmsLevel rms_level_ RTC_ACCESS_ON(encoder_queue_);
« no previous file with comments | « voice_engine/BUILD.gn ('k') | voice_engine/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698