Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5823)

Unified Diff: audio/audio_state.h

Issue 3019513002: Remove the VoiceEngineObserver callback interface. (Closed)
Patch Set: rebase + build error Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « audio/audio_send_stream_unittest.cc ('k') | audio/audio_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: audio/audio_state.h
diff --git a/audio/audio_state.h b/audio/audio_state.h
index 16d66380e2e3bf085baf944a27dbf214dcb0b939..c9c2cc561e9e63b445a34d2ffcc8ad44ea010283 100644
--- a/audio/audio_state.h
+++ b/audio/audio_state.h
@@ -22,8 +22,7 @@
namespace webrtc {
namespace internal {
-class AudioState final : public webrtc::AudioState,
- public webrtc::VoiceEngineObserver {
+class AudioState final : public webrtc::AudioState {
public:
explicit AudioState(const AudioState::Config& config);
~AudioState() override;
@@ -42,9 +41,6 @@ class AudioState final : public webrtc::AudioState,
int AddRef() const override;
int Release() const override;
- // webrtc::VoiceEngineObserver implementation.
- void CallbackOnError(int channel_id, int err_code) override;
-
rtc::ThreadChecker thread_checker_;
rtc::ThreadChecker process_thread_checker_;
const webrtc::AudioState::Config config_;
@@ -52,11 +48,6 @@ class AudioState final : public webrtc::AudioState,
// We hold one interface pointer to the VoE to make sure it is kept alive.
ScopedVoEInterface<VoEBase> voe_base_;
- // The critical section isn't strictly needed in this case, but xSAN bots may
- // trigger on unprotected cross-thread access.
- rtc::CriticalSection crit_sect_;
- bool typing_noise_detected_ RTC_GUARDED_BY(crit_sect_) = false;
-
// Reference count; implementation copied from rtc::RefCountedObject.
mutable volatile int ref_count_ = 0;
« no previous file with comments | « audio/audio_send_stream_unittest.cc ('k') | audio/audio_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698