Delete member VideoReceiveStream::Config::Rtp::ulpfec.

media/engine/webrtcvideoengine.cc

Index: media/engine/webrtcvideoengine.cc
diff --git a/media/engine/webrtcvideoengine.cc b/media/engine/webrtcvideoengine.cc
index 29fc442cb1f2742a88ba882107abec1fa5c88eca..edc875f6de7b1cc041d9cde3b6ab9a2dd2623239 100644
--- a/media/engine/webrtcvideoengine.cc
+++ b/media/engine/webrtcvideoengine.cc
@@ -2263,14 +2263,15 @@ void WebRtcVideoChannel::WebRtcVideoReceiveStream::ConfigureCodecs(
     RTC_CHECK(did_insert);
   }
 

[brandtr, 2017/09/21 08:49:40]

Maybe we should add a RTC_DCHECK(!recv_codecs.empty()) here, WDYT? I quickly
looked through the call sites and I couldn't see a guarantee that recv_codecs is
not empty there.

[nisse-webrtc, 2017/09/21 08:57:29]

Added a DCHECK at the top of the method.

I don't know what this is intended to do; if it in some way supports multiple
codecs, but configures RTP based only on the first of them.

-  config_.rtp.ulpfec = recv_codecs.front().ulpfec;
+  const auto& codec = recv_codecs.front();
+  config_.rtp.ulpfec_payload_type = codec.ulpfec.ulpfec_payload_type;
+  config_.rtp.red_payload_type = codec.ulpfec.red_payload_type;
 
-  config_.rtp.nack.rtp_history_ms =
-      HasNack(recv_codecs.begin()->codec) ? kNackHistoryMs : 0;
-  if (config_.rtp.ulpfec.red_rtx_payload_type != -1) {
+  config_.rtp.nack.rtp_history_ms = HasNack(codec.codec) ? kNackHistoryMs : 0;
+  if (codec.ulpfec.red_rtx_payload_type != -1) {
     config_.rtp
-        .rtx_associated_payload_types[config_.rtp.ulpfec.red_rtx_payload_type] =
-        config_.rtp.ulpfec.red_payload_type;
+        .rtx_associated_payload_types[codec.ulpfec.red_rtx_payload_type] =
+        codec.ulpfec.red_payload_type;
   }
 }