Delete member VideoReceiveStream::Config::Rtp::ulpfec.

media/engine/webrtcvideoengine.cc

Index: media/engine/webrtcvideoengine.cc
diff --git a/media/engine/webrtcvideoengine.cc b/media/engine/webrtcvideoengine.cc
index 29fc442cb1f2742a88ba882107abec1fa5c88eca..a6724a49da0fc38ff0b01b98ba0b3f7f3e623c07 100644
--- a/media/engine/webrtcvideoengine.cc
+++ b/media/engine/webrtcvideoengine.cc
@@ -2263,14 +2263,16 @@ void WebRtcVideoChannel::WebRtcVideoReceiveStream::ConfigureCodecs(
     RTC_CHECK(did_insert);
   }
 
-  config_.rtp.ulpfec = recv_codecs.front().ulpfec;
+  config_.rtp.ulpfec_payload_type =
+      recv_codecs.front().ulpfec.ulpfec_payload_type;

[brandtr, 2017/09/21 08:11:33]

Maybe nicer to keep a const ref to |recv_codecs.front()|, as you use it four
times?

[nisse-webrtc, 2017/09/21 08:37:46]

Done.

+  config_.rtp.red_payload_type = recv_codecs.front().ulpfec.red_payload_type;
 
   config_.rtp.nack.rtp_history_ms =
       HasNack(recv_codecs.begin()->codec) ? kNackHistoryMs : 0;

[nisse-webrtc, 2017/09/21 08:37:46]

And here for some reason |begin()->| is used instead of |front().|, but that
should be the same, right?

[brandtr, 2017/09/21 08:45:22]

I believe so. This is probably an artefact of different people using different
styles, without looking at the adjacent code.

-  if (config_.rtp.ulpfec.red_rtx_payload_type != -1) {
-    config_.rtp
-        .rtx_associated_payload_types[config_.rtp.ulpfec.red_rtx_payload_type] =
-        config_.rtp.ulpfec.red_payload_type;
+  if (recv_codecs.front().ulpfec.red_rtx_payload_type != -1) {
+    config_.rtp.rtx_associated_payload_types[recv_codecs.front()
+                                                 .ulpfec.red_rtx_payload_type] =
+        recv_codecs.front().ulpfec.red_payload_type;
   }
 }