Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Issue 3016563002: Rename 'warmCache' to 'warm_cache' (Closed)

Created:
3 years, 3 months ago by yukiy
Modified:
3 years, 3 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Rename 'warmCache' to 'warm_cache' This CL renames an identifier 'warmCache' to 'warm_cache' as the same form with others. BUG=chromium:736697 Review-Url: https://chromiumcodereview.appspot.com/3016563002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e1aa3179fac3ded8df9856820f270694572a10d3

Patch Set 1 #

Total comments: 4

Patch Set 2 : do not remove ensure_diskcache #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M telemetry/telemetry/page/cache_temperature.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M telemetry/telemetry/page/cache_temperature_unittest.py View 1 3 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (8 generated)
yukiy
PTAL
3 years, 3 months ago (2017-09-19 07:42:39 UTC) #2
shimazu
Code lgtm. Please use a bit more detailed title like "Remove redundant tab preparation on ...
3 years, 3 months ago (2017-09-19 07:57:44 UTC) #3
yukiy
On 2017/09/19 07:57:44, shimazu wrote: > Code lgtm. > Please use a bit more detailed ...
3 years, 3 months ago (2017-09-19 08:35:52 UTC) #5
kouhei (in TOK)
lgtm On 2017/09/19 08:35:52, yukiy wrote: > On 2017/09/19 07:57:44, shimazu wrote: > > Code ...
3 years, 3 months ago (2017-09-19 09:04:30 UTC) #6
nednguyen
https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py File telemetry/telemetry/page/cache_temperature.py (left): https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py#oldcode68 telemetry/telemetry/page/cache_temperature.py:68: tab.Navigate("http://does.not.exist") Wait, where is this logic not needed any ...
3 years, 3 months ago (2017-09-19 09:40:27 UTC) #7
yukiy
https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py File telemetry/telemetry/page/cache_temperature.py (left): https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py#oldcode68 telemetry/telemetry/page/cache_temperature.py:68: tab.Navigate("http://does.not.exist") On 2017/09/19 09:40:27, nednguyen wrote: > Wait, where ...
3 years, 3 months ago (2017-09-19 10:08:20 UTC) #8
nednguyen
https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py File telemetry/telemetry/page/cache_temperature.py (left): https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py#oldcode68 telemetry/telemetry/page/cache_temperature.py:68: tab.Navigate("http://does.not.exist") On 2017/09/19 10:08:20, yukiy wrote: > On 2017/09/19 ...
3 years, 3 months ago (2017-09-19 10:25:00 UTC) #9
nednguyen
On 2017/09/19 10:25:00, nednguyen wrote: > https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py > File telemetry/telemetry/page/cache_temperature.py (left): > > https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py#oldcode68 > ...
3 years, 3 months ago (2017-09-19 10:54:22 UTC) #10
yukiy
Sorry for late reply, PTAL! https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py File telemetry/telemetry/page/cache_temperature.py (left): https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py#oldcode68 telemetry/telemetry/page/cache_temperature.py:68: tab.Navigate("http://does.not.exist") On 2017/09/19 10:25:00, ...
3 years, 3 months ago (2017-09-21 07:20:17 UTC) #13
nednguyen
On 2017/09/21 07:20:17, yukiy wrote: > Sorry for late reply, PTAL! > > https://codereview.chromium.org/3016563002/diff/1/telemetry/telemetry/page/cache_temperature.py > ...
3 years, 3 months ago (2017-09-21 08:56:49 UTC) #14
nednguyen
On 2017/09/21 08:56:49, nednguyen wrote: > On 2017/09/21 07:20:17, yukiy wrote: > > Sorry for ...
3 years, 3 months ago (2017-09-21 09:00:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3016563002/40001
3 years, 3 months ago (2017-09-21 09:10:11 UTC) #18
commit-bot: I haz the power
3 years, 3 months ago (2017-09-21 09:42:08 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698