Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: packages/initialize/lib/build/initializer_plugin.dart

Issue 3015713002: Roll to pickup pool changes
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/initialize/CHANGELOG.md ('k') | packages/initialize/lib/src/init_method.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/initialize/lib/build/initializer_plugin.dart
diff --git a/packages/initialize/lib/build/initializer_plugin.dart b/packages/initialize/lib/build/initializer_plugin.dart
index f049df0aa51b2f7542a6a4de154361d4a568d927..1a004dd1bd7af9753834afac255a7a44daed1da3 100644
--- a/packages/initialize/lib/build/initializer_plugin.dart
+++ b/packages/initialize/lib/build/initializer_plugin.dart
@@ -235,7 +235,7 @@ class DefaultInitializerPlugin implements InitializerPlugin {
buffer.write(_evaluateExpression(expression, pluginData));
} else {
libraryPrefixes.putIfAbsent(
- element.library, () => 'i${libraryPrefixes.length}');
+ element.library, () => 'i${libraryPrefixes.length}');
buffer.write('${libraryPrefixes[element.library]}.');
if (element is ClassElement) {
@@ -263,8 +263,7 @@ class DefaultInitializerPlugin implements InitializerPlugin {
return buffer.toString();
}
- _evaluateExpression(
- Expression expression, InitializerPluginData pluginData) {
+ _evaluateExpression(Expression expression, InitializerPluginData pluginData) {
var logger = pluginData.logger;
var result = pluginData.resolver.evaluateConstant(
pluginData.initializer.targetElement.library, expression);
@@ -302,9 +301,9 @@ class DefaultInitializerPlugin implements InitializerPlugin {
object.toIntValue() ??
object.toStringValue();
if (value == null) {
- value = object.toListValue();
- if (value != null) {
- return value.map((DartObject element) => _getValue(element)).toList();
+ List list = object.toListValue();
+ if (list != null) {
+ return list.map((DartObject element) => _getValue(element)).toList();
}
Map<DartObject, DartObject> map = object.toMapValue();
if (map != null) {
« no previous file with comments | « packages/initialize/CHANGELOG.md ('k') | packages/initialize/lib/src/init_method.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698