Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: packages/csslib/lib/src/analyzer.dart

Issue 3015713002: Roll to pickup pool changes
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/csslib/lib/parser.dart ('k') | packages/csslib/lib/src/css_printer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/csslib/lib/src/analyzer.dart
diff --git a/packages/csslib/lib/src/analyzer.dart b/packages/csslib/lib/src/analyzer.dart
index 6c6ba6d6143a284c5fb11bf377db2c9eb7d5073f..0bfb2f326028ce371fdb32c42932814b475d5eba 100644
--- a/packages/csslib/lib/src/analyzer.dart
+++ b/packages/csslib/lib/src/analyzer.dart
@@ -222,7 +222,7 @@ class ExpandNestedSelectors extends Visitor {
// If any expandedRuleSets and we're back at the top-level rule set then
// there were nested rule set(s).
if (_parentRuleSet == null) {
- if (!_expandedRuleSets.isEmpty) {
+ if (_expandedRuleSets.isNotEmpty) {
// Remember ruleset to replace with these flattened rulesets.
_expansions[node] = _expandedRuleSets;
_expandedRuleSets = [];
@@ -278,8 +278,8 @@ class ExpandNestedSelectors extends Visitor {
// Substitue the & with the parent selector and only use a combinator
// descendant if & is prefix by a sequence with an empty name e.g.,
// "... + &", "&", "... ~ &", etc.
- var hasPrefix = !newSequence.isEmpty &&
- !newSequence.last.simpleSelector.name.isEmpty;
+ var hasPrefix = newSequence.isNotEmpty &&
+ newSequence.last.simpleSelector.name.isNotEmpty;
newSequence.addAll(
hasPrefix ? _convertToDescendentSequence(parent) : parent);
} else {
@@ -906,7 +906,7 @@ class AllExtends extends Visitor {
SelectorGroup _currSelectorGroup;
int _currDeclIndex;
- List<int> _extendsToRemove = [];
+ final List<int> _extendsToRemove = [];
void visitRuleSet(RuleSet node) {
var oldSelectorGroup = _currSelectorGroup;
« no previous file with comments | « packages/csslib/lib/parser.dart ('k') | packages/csslib/lib/src/css_printer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698