modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc - Issue 3015703002: Splitting cl https://codereview.webrtc.org/3011373002 into two: updating v1.7 and adding unit tests…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc

Issue 3015703002: Splitting cl https://codereview.webrtc.org/3011373002 into two: updating v1.7 and adding unit tests… (Closed)

Patch Set: Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc ('k') | modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc

diff --git a/modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc b/modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc

index aba7657846afae31050aa0913135ecc938c244a4..ce32be8f7e03c85fcb0df4bfda623b0e9b74e42a 100644

--- a/modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc

+++ b/modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc

@@ -56,8 +56,8 @@ TEST_F(VideoProcessorIntegrationTestMediaCodec, ForemanCif500kbpsVp8) {

QualityThresholds quality_thresholds(30.0, 15.0, 0.90, 0.40);

- ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds,

- kNoVisualizationParams);

+ ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds,

+ &quality_thresholds, nullptr, kNoVisualizationParams);

}

TEST_F(VideoProcessorIntegrationTestMediaCodec,

@@ -88,8 +88,8 @@ TEST_F(VideoProcessorIntegrationTestMediaCodec,

QualityThresholds quality_thresholds(33.0, 30.0, 0.90, 0.85);

- ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds,

- kNoVisualizationParams);

+ ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds,

+ &quality_thresholds, nullptr, kNoVisualizationParams);

}

#endif // defined(WEBRTC_ANDROID)