Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 3015633002: [Telemetry] Include debugging info when foreground tab is missing (Closed)

Created:
3 years, 3 months ago by perezju
Modified:
3 years, 3 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Include debugging info when foreground tab is missing Raise a subclass of exceptions.Error when the foreground tab is not found, so that more debug information is included in the logs. BUG=chromium:760901 Review-Url: https://chromiumcodereview.appspot.com/3015633002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6926f20b399dfe1cafe1d1867912cc799f434a8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M telemetry/telemetry/core/exceptions.py View 1 chunk +4 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/browser/browser.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
perezju
3 years, 3 months ago (2017-09-20 11:57:32 UTC) #2
nednguyen
lgtm
3 years, 3 months ago (2017-09-20 12:10:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3015633002/1
3 years, 3 months ago (2017-09-20 12:43:59 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-09-20 13:16:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698