Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 3014653002: [Soundwave] Add tool that displays alerts and related noise and bug data.

Created:
1 year, 9 months ago by rnephew (Reviews Here)
Modified:
1 year, 9 months ago
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Soundwave] Add tool that displays alerts and related noise and bug data. BUG=chromium:769027

Patch Set 1 #

Patch Set 2 : [Soundwave] Add tool that displays alerts and related noise and bug data. #

Patch Set 3 : Fix error when metric is None when generating noise data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -0 lines) Patch
A experimental/soundwave/alert_analyzer.py View 1 2 1 chunk +210 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (2 generated)
rnephew (Reviews Here)
1 year, 9 months ago (2017-09-26 21:45:13 UTC) #2
rnephew (Reviews Here)
On 2017/09/26 21:45:13, rnephew (Reviews Here) wrote: The json file is example output from the ...
1 year, 9 months ago (2017-09-26 21:46:17 UTC) #3
nednguyen
On 2017/09/26 21:46:17, rnephew (Reviews Here) wrote: > On 2017/09/26 21:45:13, rnephew (Reviews Here) wrote: ...
1 year, 9 months ago (2017-09-26 21:57:13 UTC) #4
rnephew (Reviews Here)
> You should file a tracking bug for this effort, Randy. I suggest using crbug ...
1 year, 9 months ago (2017-09-26 22:01:25 UTC) #6
perezju
I feel it's probably a bit too early to start writing code, and we should ...
1 year, 9 months ago (2017-09-27 08:10:49 UTC) #7
nednguyen
On 2017/09/27 08:10:49, perezju wrote: > I feel it's probably a bit too early to ...
1 year, 9 months ago (2017-09-27 10:21:09 UTC) #8
rnephew (Reviews Here)
The major problem with writing a design first is that you have to have some ...
1 year, 9 months ago (2017-09-27 15:14:59 UTC) #9
nednguyen(REVIEW IN OTHER ACC)
On 2017/09/27 15:14:59, rnephew (Reviews Here) wrote: > The major problem with writing a design ...
1 year, 9 months ago (2017-09-27 15:44:57 UTC) #10
nednguyen
lgtm so you can iterate on this. For the next step, I suggest: 1) Sync ...
1 year, 9 months ago (2017-09-27 18:47:43 UTC) #11
rnephew (Reviews Here)
On 2017/09/27 18:47:43, nednguyen wrote: > lgtm so you can iterate on this. For the ...
1 year, 9 months ago (2017-09-27 18:57:59 UTC) #12
nednguyen
On 2017/09/27 18:57:59, rnephew (Reviews Here) wrote: > On 2017/09/27 18:47:43, nednguyen wrote: > > ...
1 year, 9 months ago (2017-09-27 19:02:45 UTC) #13
rnephew (Reviews Here)
On 2017/09/27 19:02:45, nednguyen wrote: > On 2017/09/27 18:57:59, rnephew (Reviews Here) wrote: > > ...
1 year, 9 months ago (2017-09-27 19:07:18 UTC) #14
nednguyen
On 2017/09/27 19:07:18, rnephew (Reviews Here) wrote: > On 2017/09/27 19:02:45, nednguyen wrote: > > ...
1 year, 9 months ago (2017-09-27 19:11:37 UTC) #15
rnephew (Reviews Here)
1 year, 9 months ago (2017-09-27 19:11:54 UTC) #16
On 2017/09/27 19:07:18, rnephew (Reviews Here) wrote:
> On 2017/09/27 19:02:45, nednguyen wrote:
> > On 2017/09/27 18:57:59, rnephew (Reviews Here) wrote:
> > > On 2017/09/27 18:47:43, nednguyen wrote:
> > > > lgtm so you can iterate on this. For the next step, I suggest:
> > > > 1) Sync up with Juan on the directions. He has a lot of experience with
> > these
> > > > analysis, so can probably share valueable insights 
> > > > 2) Improve the script so that you don't need to hit real network anytime
> you
> > > > iterate your analysis. I suggest making it possible to fetch data from
> > network
> > > > once, and reuse it many time when iterating.
> > > 
> > > Part 2 is exactly the purpose of this script. I can pull down the data and
> > reuse
> > > it over and over again, as it is saved in a json file.
> > 
> > Which script analyze local json file? I don't see alert_analyzer.py's
> > commandline args support taking in an existing json file.
> 
> I have not created any helper script for analyzing the data it pulls down and
> processes. I think that maybe I should rename it from 'alert_analyzer' to
> 'alert_processor' or something similar, since its not really analyzing
anything
> just pulling data and generating noise data for the metrics involved in the
> alerts.

Since reitveld is going read only soon, we should move this discussion to the
email Juan started. I will be moving this over to gerrit soon.

Powered by Google App Engine
This is Rietveld 408576698