Fix Gn untracked headers in webrtc/call

Fix Gn untracked headers in webrtc/call


BUG=webrtc:7641
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3013063002
Cr-Commit-Position: refs/heads/master@{#19824}

[charujain, 2017-09-14 15:30:12]

Description was changed from

==========
Fix Gn untracked headers in webrtc/call


TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3013063002
Cr-Commit-Position: refs/heads/master@{#19824}
==========

to

==========
Fix Gn untracked headers in webrtc/call


BUG=webrtc:7641
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3013063002
Cr-Commit-Position: refs/heads/master@{#19824}
==========

[charujain, 2017-09-14 15:32:10]

charujain@webrtc.org changed reviewers:
+ charujain@webrtc.org, kjellander@google.com, mbonadei@webrtc.org

[charujain, 2017-09-14 15:32:11]

https://codereview.webrtc.org/3014543002/diff/1/webrtc/call/BUILD.gn
File webrtc/call/BUILD.gn (right):

https://codereview.webrtc.org/3014543002/diff/1/webrtc/call/BUILD.gn#newcode91
webrtc/call/BUILD.gn:91: rtc_source_set("bitrate_allocator_header") {
Ideally, this should be included in "call" target where "bitrate_allocator.cc"
sits. But adding there is leading to cyclic dependency. So I created separate
target.

[charujain, 2017-09-19 08:57:52]

On 2017/09/14 15:32:11, charujain wrote:
> https://codereview.webrtc.org/3014543002/diff/1/webrtc/call/BUILD.gn
> File webrtc/call/BUILD.gn (right):
> 
> https://codereview.webrtc.org/3014543002/diff/1/webrtc/call/BUILD.gn#newcode91
> webrtc/call/BUILD.gn:91: rtc_source_set("bitrate_allocator_header") {
> Ideally, this should be included in "call" target where "bitrate_allocator.cc"
> sits. But adding there is leading to cyclic dependency. So I created separate
> target.

PTAL

[mbonadei, 2017-09-19 09:00:42]

https://codereview.webrtc.org/3014543002/diff/40001/call/BUILD.gn
File call/BUILD.gn (right):

https://codereview.webrtc.org/3014543002/diff/40001/call/BUILD.gn#newcode91
call/BUILD.gn:91: rtc_source_set("bitrate_allocator_header") {
Is it possible to move this into the "call" target?

If not I think we should remove the _header from the name.

[kjellander_webrtc, 2017-09-19 16:00:47]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org
- kjellander@google.com

[kjellander_webrtc, 2017-09-19 16:01:43]

https://codereview.webrtc.org/3014543002/diff/40001/call/BUILD.gn
File call/BUILD.gn (right):

https://codereview.webrtc.org/3014543002/diff/40001/call/BUILD.gn#newcode91
call/BUILD.gn:91: rtc_source_set("bitrate_allocator_header") {
On 2017/09/19 09:00:42, mbonadei wrote:
> Is it possible to move this into the "call" target?
> 
> If not I think we should remove the _header from the name.

Yeah, let's ask owners for advice here.

[charujain, 2017-09-22 11:19:16]

charujain@webrtc.org changed reviewers:
+ stefan@webrtc.org

[charujain, 2017-09-22 11:19:17]

+stefan for advice

[kjellander_webrtc, 2017-09-28 08:46:17]

On 2017/09/22 11:19:17, charujain wrote:
> +stefan for advice

ping