Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3066)

Unified Diff: call/rampup_tests.cc

Issue 3013853002: Disable RampUpTest.UpDownUpTransportSequenceNumberPacketLoss on Linux due to flakiness. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: call/rampup_tests.cc
diff --git a/call/rampup_tests.cc b/call/rampup_tests.cc
index 6ce2efd6ac58c14edbff4905c8b9e447729ee064..21fd361c4cd4abcbf28316f71e02bf1f05e3973a 100644
--- a/call/rampup_tests.cc
+++ b/call/rampup_tests.cc
@@ -584,7 +584,15 @@ TEST_F(RampUpTest, UpDownUpTransportSequenceNumberRtx) {
// TODO(holmer): Tests which don't report perf stats should be moved to a
// different executable since they per definition are not perf tests.
-TEST_F(RampUpTest, UpDownUpTransportSequenceNumberPacketLoss) {
+// Crashes on Linux only, see webrtc:7919.
+#if defined(WEBRTC_LINUX)
+#define MAYBE_UpDownUpTransportSequenceNumberPacketLoss \
+ DISABLED_UpDownUpTransportSequenceNumberPacketLoss
+#else
+#define MAYBE_UpDownUpTransportSequenceNumberPacketLoss \
+ UpDownUpTransportSequenceNumberPacketLoss
+#endif
+TEST_F(RampUpTest, MAYBE_UpDownUpTransportSequenceNumberPacketLoss) {
std::vector<int> loss_rates = {20, 0, 0, 0};
RampUpDownUpTester test(1, 0, 1, kStartBitrateBps,
RtpExtension::kTransportSequenceNumberUri, true,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698