Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1906)

Unified Diff: dashboard/dashboard/services/gitiles_service_test.py

Issue 3013753002: [pinpoint] Increase Gitiles service timeout. (Closed)
Patch Set: Dashboard unit tests. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/services/gitiles_service.py ('k') | dashboard/dashboard/start_try_job_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/services/gitiles_service_test.py
diff --git a/dashboard/dashboard/services/gitiles_service_test.py b/dashboard/dashboard/services/gitiles_service_test.py
index 73cdeff2faa93e45be1c8d99247efa2b1f8afa05..735d8e10f79c337a3c3760c7981fe390df1c3df1 100644
--- a/dashboard/dashboard/services/gitiles_service_test.py
+++ b/dashboard/dashboard/services/gitiles_service_test.py
@@ -49,7 +49,8 @@ class GitilesTest(unittest.TestCase):
'commit_hash'),
return_value)
mock_fetch.assert_called_once_with(
- 'https://chromium.googlesource.com/repo/+/commit_hash?format=JSON')
+ 'https://chromium.googlesource.com/repo/+/commit_hash?format=JSON',
+ deadline=10)
def testCommitRange(self, mock_fetch):
return_value = {
@@ -95,7 +96,8 @@ class GitilesTest(unittest.TestCase):
return_value['log'])
mock_fetch.assert_called_once_with(
'https://chromium.googlesource.com/repo/+log/'
- 'commit_0_hash..commit_2_hash?format=JSON')
+ 'commit_0_hash..commit_2_hash?format=JSON',
+ deadline=10)
def testCommitRangePaginated(self, mock_fetch):
return_value_1 = {
@@ -127,7 +129,8 @@ class GitilesTest(unittest.TestCase):
'commit_hash', 'path'),
'hello')
mock_fetch.assert_called_once_with(
- 'https://chromium.googlesource.com/repo/+/commit_hash/path?format=TEXT')
+ 'https://chromium.googlesource.com/repo/+/commit_hash/path?format=TEXT',
+ deadline=10)
def testRetries(self, mock_fetch):
mock_fetch.side_effect = urlfetch.Error()
« no previous file with comments | « dashboard/dashboard/services/gitiles_service.py ('k') | dashboard/dashboard/start_try_job_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698