Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: dashboard/dashboard/elements/chart-container.html

Issue 3013743002: Dashboard - Populate bug_id with uri parameter if available. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/elements/chart-container-test.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 Copyright 2016 The Chromium Authors. All rights reserved. 3 Copyright 2016 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 <!-- 7 <!--
8 The chart-container element represents one chart and all related functionality, 8 The chart-container element represents one chart and all related functionality,
9 including a legend listing different traces that can be plotted on the same 9 including a legend listing different traces that can be plotted on the same
10 chart, a revision range selecting mini-chart at the bottom, and all of the alert 10 chart, a revision range selecting mini-chart at the bottom, and all of the alert
(...skipping 2228 matching lines...) Expand 10 before | Expand all | Expand 10 after
2239 2239
2240 // Set the alert-related properties of the tooltip. 2240 // Set the alert-related properties of the tooltip.
2241 if (opt_alerts === undefined) { 2241 if (opt_alerts === undefined) {
2242 opt_alerts = null; 2242 opt_alerts = null;
2243 } 2243 }
2244 this.$.tooltip.alerts = opt_alerts; 2244 this.$.tooltip.alerts = opt_alerts;
2245 if (opt_triaged === undefined) { 2245 if (opt_triaged === undefined) {
2246 opt_triaged = null; 2246 opt_triaged = null;
2247 } 2247 }
2248 this.$.tooltip.triagedAlerts = opt_triaged; 2248 this.$.tooltip.triagedAlerts = opt_triaged;
2249
2250 const uriBugId = uri.getParameter('bug_id');
2251
2249 if (annotation.g_anomaly) { 2252 if (annotation.g_anomaly) {
2250 if (annotation.g_anomaly.bug_id) { 2253 if (annotation.g_anomaly.bug_id) {
2251 this.$.tooltip.bugId = annotation.g_anomaly.bug_id; 2254 this.$.tooltip.bugId = annotation.g_anomaly.bug_id;
2252 this.$.tooltip.alertInvalidOrIgnored = 2255 this.$.tooltip.alertInvalidOrIgnored =
2253 annotation.g_anomaly.bug_id < 0; 2256 annotation.g_anomaly.bug_id < 0;
2254 this.$.tooltip.alertKey = annotation.g_anomaly.key; 2257 this.$.tooltip.alertKey = annotation.g_anomaly.key;
2255 } 2258 }
2256 this.$.tooltip.recovered = annotation.g_anomaly.recovered; 2259 this.$.tooltip.recovered = annotation.g_anomaly.recovered;
2260 } else if (uriBugId !== null) {
2261 this.$.tooltip.bugId = uriBugId;
2257 } 2262 }
2258 2263
2259 this.$.tooltip.bisectInfo = { 2264 this.$.tooltip.bisectInfo = {
2260 canBisect: series.can_bisect, 2265 canBisect: series.can_bisect,
2261 badRev: this.getRevisionForBisect(jsonSeriesIndex, dataIndex), 2266 badRev: this.getRevisionForBisect(jsonSeriesIndex, dataIndex),
2262 goodRev: this.getRevisionForBisect(jsonSeriesIndex, dataIndex - 1), 2267 goodRev: this.getRevisionForBisect(jsonSeriesIndex, dataIndex - 1),
2263 badRevRepo: this.getDefaultRevisionRepository( 2268 badRevRepo: this.getDefaultRevisionRepository(
2264 jsonSeriesIndex, dataIndex), 2269 jsonSeriesIndex, dataIndex),
2265 goodRevRepo: this.getDefaultRevisionRepository( 2270 goodRevRepo: this.getDefaultRevisionRepository(
2266 jsonSeriesIndex, dataIndex - 1), 2271 jsonSeriesIndex, dataIndex - 1),
(...skipping 654 matching lines...) Expand 10 before | Expand all | Expand 10 after
2921 // TODO(#3841): Use dom-change or observeNodes instead of async(). 2926 // TODO(#3841): Use dom-change or observeNodes instead of async().
2922 this.async(() => { 2927 this.async(() => {
2923 this.set('selectedRelatedTab', 2928 this.set('selectedRelatedTab',
2924 this.relatedTabs[this.selectedRelatedTabIndex].sparklines); 2929 this.relatedTabs[this.selectedRelatedTabIndex].sparklines);
2925 }); 2930 });
2926 }, 2931 },
2927 }); 2932 });
2928 })(); 2933 })();
2929 </script> 2934 </script>
2930 </dom-module> 2935 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | dashboard/dashboard/elements/chart-container-test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698