Index: dashboard/dashboard/pinpoint/models/change/commit_test.py |
diff --git a/dashboard/dashboard/pinpoint/models/change/commit_test.py b/dashboard/dashboard/pinpoint/models/change/commit_test.py |
index 4aef4f29d7fa519955665b02b112e78d0dda6ce2..264207e4f97c76667b5f3b6009d98f58e20d4f57 100644 |
--- a/dashboard/dashboard/pinpoint/models/change/commit_test.py |
+++ b/dashboard/dashboard/pinpoint/models/change/commit_test.py |
@@ -122,13 +122,14 @@ class MidpointTest(_CommitTest): |
commit_a = commit.Commit('chromium', '0e57e2b') |
commit_b = commit.Commit('chromium', 'babe852') |
- self.assertEqual(commit.Commit.Midpoint(commit_a, commit_b), |
- commit.Commit('chromium', '949b36d')) |
+ expected = commit.Commit('chromium', '949b36d'), (2, 2) |
+ self.assertEqual(commit.Commit.Midpoint(commit_a, commit_b), expected) |
perezju
2017/09/19 15:58:05
Can you also add a success test with an even numbe
|
def testSameCommit(self): |
commit_a = commit.Commit('chromium', '0e57e2b') |
commit_b = commit.Commit('chromium', '0e57e2b') |
- self.assertEqual(commit.Commit.Midpoint(commit_a, commit_b), commit_a) |
+ expected = commit_a, (0, 0) |
+ self.assertEqual(commit.Commit.Midpoint(commit_a, commit_b), expected) |
@mock.patch('dashboard.services.gitiles_service.CommitRange') |
def testAdjacentCommits(self, commit_range): |
@@ -136,7 +137,8 @@ class MidpointTest(_CommitTest): |
commit_a = commit.Commit('chromium', '949b36d') |
commit_b = commit.Commit('chromium', 'b57345e') |
- self.assertEqual(commit.Commit.Midpoint(commit_a, commit_b), commit_a) |
+ expected = commit_a, (0, 1) |
+ self.assertEqual(commit.Commit.Midpoint(commit_a, commit_b), expected) |
def testRaisesWithDifferingRepositories(self): |
commit_a = commit.Commit('chromium', '0e57e2b') |