modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc - Issue 3013613002: Added configurable offsets to the per-packet overhead in ANA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc

Issue 3013613002: Added configurable offsets to the per-packet overhead in ANA. (Closed)

Patch Set: Added conversion to size_t in DCHECK. Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « modules/audio_coding/audio_network_adaptor/frame_length_controller.cc ('k') | modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor_config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc

diff --git a/modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc b/modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc

index fa0af7dde60093d9cada0eda40016455320e95a1..4c96c96f6f6010c35e1e2730f15ac93a6c99f659 100644

--- a/modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc

+++ b/modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc

@@ -20,6 +20,8 @@ namespace {

constexpr float kFlIncreasingPacketLossFraction = 0.04f;

constexpr float kFlDecreasingPacketLossFraction = 0.05f;

+constexpr int kFlIncreaseOverheadOffset = 0;

+constexpr int kFlDecreaseOverheadOffset = 0;

constexpr int kMinEncoderBitrateBps = 6000;

constexpr int kPreventOveruseMarginBps = 5000;

constexpr size_t kOverheadBytesPerPacket = 20;

@@ -46,7 +48,8 @@ std::unique_ptr<FrameLengthController> CreateController(

new FrameLengthController(FrameLengthController::Config(

encoder_frame_lengths_ms, initial_frame_length_ms,

kMinEncoderBitrateBps, kFlIncreasingPacketLossFraction,

- kFlDecreasingPacketLossFraction, frame_length_change_criteria)));

+ kFlDecreasingPacketLossFraction, kFlIncreaseOverheadOffset,

+ kFlDecreaseOverheadOffset, frame_length_change_criteria)));

return controller;

}