Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 3013523002: Move StreamConfig into its own file (Closed)
Patch Set: s/2015/2017 Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log.h
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.h b/webrtc/logging/rtc_event_log/rtc_event_log.h
index 5a7067de53dd19a3bc749a642a340679d0c11f82..7a8718deafcd71b7fa89e7c4f01b25517c9945c5 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.h
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.h
@@ -18,41 +18,13 @@
#include "webrtc/api/array_view.h"
#include "webrtc/api/rtpparameters.h"
#include "webrtc/common_types.h"
+#include "webrtc/logging/rtc_event_log/rtc_stream_config.h"
terelius 2017/09/08 12:51:50 Do we have to include it here, or is it sufficient
eladalon 2017/09/08 13:04:16 I suspect some places that are passing in objects
terelius 2017/09/08 13:16:29 Acknowledged. Please add a TODO.
eladalon 2017/09/08 13:19:57 Done.
#include "webrtc/rtc_base/platform_file.h"
namespace webrtc {
-// Forward declaration of storage class that is automatically generated from
-// the protobuf file.
namespace rtclog {
-class EventStream;
-
-struct StreamConfig {
- uint32_t local_ssrc = 0;
- uint32_t remote_ssrc = 0;
- uint32_t rtx_ssrc = 0;
- std::string rsid;
-
- bool remb = false;
- std::vector<RtpExtension> rtp_extensions;
-
- RtcpMode rtcp_mode = RtcpMode::kReducedSize;
-
- struct Codec {
- Codec(const std::string& payload_name,
- int payload_type,
- int rtx_payload_type)
- : payload_name(payload_name),
- payload_type(payload_type),
- rtx_payload_type(rtx_payload_type) {}
-
- std::string payload_name;
- int payload_type;
- int rtx_payload_type;
- };
- std::vector<Codec> codecs;
-};
-
+class EventStream; // Storage class automatically generated from protobuf.
} // namespace rtclog
class Clock;

Powered by Google App Engine
This is Rietveld 408576698