Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_packet.h

Issue 3013023004: Make rtp::Packet's destructor and constructors public (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_packet.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_packet.h b/webrtc/modules/rtp_rtcp/source/rtp_packet.h
index fb19815b59343ee8ed35dcabf45936ea29f4236f..5a02f6ca3f6413f744421c35340a84633b940408 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_packet.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_packet.h
@@ -30,6 +30,18 @@ class Packet {
static constexpr int kMinExtensionId = 1;
static constexpr int kMaxExtensionId = 14;
+ // |extensions| required for SetExtension/ReserveExtension functions during
+ // packet creating and used if available in Parse function.
+ // Adding and getting extensions will fail until |extensions| is
+ // provided via constructor or IdentifyExtensions function.
+ Packet();
+ explicit Packet(const ExtensionManager* extensions);
+ Packet(const Packet&);
+ Packet(const ExtensionManager* extensions, size_t capacity);
+ ~Packet();
+
+ Packet& operator=(const Packet&) = default;
+
// Parse and copy given buffer into Packet.
bool Parse(const uint8_t* buffer, size_t size);
bool Parse(rtc::ArrayView<const uint8_t> packet);
@@ -113,19 +125,6 @@ class Packet {
uint8_t* AllocatePayload(size_t size_bytes);
bool SetPadding(uint8_t size_bytes, Random* random);
- protected:
- // |extensions| required for SetExtension/ReserveExtension functions during
- // packet creating and used if available in Parse function.
- // Adding and getting extensions will fail until |extensions| is
- // provided via constructor or IdentifyExtensions function.
- Packet();
- explicit Packet(const ExtensionManager* extensions);
- Packet(const Packet&);
- Packet(const ExtensionManager* extensions, size_t capacity);
- ~Packet();
-
- Packet& operator=(const Packet&) = default;
-
private:
struct ExtensionInfo {
ExtensionType type;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698