Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Side by Side Diff: webrtc/sdk/android/src/jni/pc/java_native_conversion.cc

Issue 3012843002: android: add IceServer.urls field (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 return PeerConnectionInterface::kTlsCertPolicySecure; 344 return PeerConnectionInterface::kTlsCertPolicySecure;
345 } 345 }
346 346
347 void JavaToNativeIceServers(JNIEnv* jni, 347 void JavaToNativeIceServers(JNIEnv* jni,
348 jobject j_ice_servers, 348 jobject j_ice_servers,
349 PeerConnectionInterface::IceServers* ice_servers) { 349 PeerConnectionInterface::IceServers* ice_servers) {
350 for (jobject j_ice_server : Iterable(jni, j_ice_servers)) { 350 for (jobject j_ice_server : Iterable(jni, j_ice_servers)) {
351 jclass j_ice_server_class = GetObjectClass(jni, j_ice_server); 351 jclass j_ice_server_class = GetObjectClass(jni, j_ice_server);
352 jfieldID j_ice_server_uri_id = 352 jfieldID j_ice_server_uri_id =
353 GetFieldID(jni, j_ice_server_class, "uri", "Ljava/lang/String;"); 353 GetFieldID(jni, j_ice_server_class, "uri", "Ljava/lang/String;");
354 jfieldID j_ice_server_urls_id =
355 GetFieldID(jni, j_ice_server_class, "urls", "Ljava/util/List;");
354 jfieldID j_ice_server_username_id = 356 jfieldID j_ice_server_username_id =
355 GetFieldID(jni, j_ice_server_class, "username", "Ljava/lang/String;"); 357 GetFieldID(jni, j_ice_server_class, "username", "Ljava/lang/String;");
356 jfieldID j_ice_server_password_id = 358 jfieldID j_ice_server_password_id =
357 GetFieldID(jni, j_ice_server_class, "password", "Ljava/lang/String;"); 359 GetFieldID(jni, j_ice_server_class, "password", "Ljava/lang/String;");
358 jfieldID j_ice_server_tls_cert_policy_id = 360 jfieldID j_ice_server_tls_cert_policy_id =
359 GetFieldID(jni, j_ice_server_class, "tlsCertPolicy", 361 GetFieldID(jni, j_ice_server_class, "tlsCertPolicy",
360 "Lorg/webrtc/PeerConnection$TlsCertPolicy;"); 362 "Lorg/webrtc/PeerConnection$TlsCertPolicy;");
361 jobject j_ice_server_tls_cert_policy = 363 jobject j_ice_server_tls_cert_policy =
362 GetObjectField(jni, j_ice_server, j_ice_server_tls_cert_policy_id); 364 GetObjectField(jni, j_ice_server, j_ice_server_tls_cert_policy_id);
363 jfieldID j_ice_server_hostname_id = 365 jfieldID j_ice_server_hostname_id =
364 GetFieldID(jni, j_ice_server_class, "hostname", "Ljava/lang/String;"); 366 GetFieldID(jni, j_ice_server_class, "hostname", "Ljava/lang/String;");
365 jfieldID j_ice_server_tls_alpn_protocols_id = GetFieldID( 367 jfieldID j_ice_server_tls_alpn_protocols_id = GetFieldID(
366 jni, j_ice_server_class, "tlsAlpnProtocols", "Ljava/util/List;"); 368 jni, j_ice_server_class, "tlsAlpnProtocols", "Ljava/util/List;");
367 jstring uri = reinterpret_cast<jstring>( 369 jstring uri = reinterpret_cast<jstring>(
368 GetObjectField(jni, j_ice_server, j_ice_server_uri_id)); 370 GetNullableObjectField(jni, j_ice_server, j_ice_server_uri_id));
371 jstring urls = reinterpret_cast<jstring>(
372 GetNullableObjectField(jni, j_ice_server, j_ice_server_urls_id));
369 jstring username = reinterpret_cast<jstring>( 373 jstring username = reinterpret_cast<jstring>(
370 GetObjectField(jni, j_ice_server, j_ice_server_username_id)); 374 GetObjectField(jni, j_ice_server, j_ice_server_username_id));
371 jstring password = reinterpret_cast<jstring>( 375 jstring password = reinterpret_cast<jstring>(
372 GetObjectField(jni, j_ice_server, j_ice_server_password_id)); 376 GetObjectField(jni, j_ice_server, j_ice_server_password_id));
373 PeerConnectionInterface::TlsCertPolicy tls_cert_policy = 377 PeerConnectionInterface::TlsCertPolicy tls_cert_policy =
374 JavaToNativeTlsCertPolicy(jni, j_ice_server_tls_cert_policy); 378 JavaToNativeTlsCertPolicy(jni, j_ice_server_tls_cert_policy);
375 jstring hostname = reinterpret_cast<jstring>( 379 jstring hostname = reinterpret_cast<jstring>(
376 GetObjectField(jni, j_ice_server, j_ice_server_hostname_id)); 380 GetObjectField(jni, j_ice_server, j_ice_server_hostname_id));
377 jobject tls_alpn_protocols = GetNullableObjectField( 381 jobject tls_alpn_protocols = GetNullableObjectField(
378 jni, j_ice_server, j_ice_server_tls_alpn_protocols_id); 382 jni, j_ice_server, j_ice_server_tls_alpn_protocols_id);
379 PeerConnectionInterface::IceServer server; 383 PeerConnectionInterface::IceServer server;
380 server.uri = JavaToStdString(jni, uri); 384 if (urls != nullptr) {
385 server.urls = JavaToStdVectorStrings(jni, urls);
386 } else if (uri != nullptr) {
387 server.uri = JavaToStdString(jni, uri);
sakal 2017/09/07 07:46:36 Just ignore the uri paramater and set server.uri t
korniltsev 2017/09/07 20:33:46 Done.
388 } else {
389 RTC_NOTREACHED();
390 }
381 server.username = JavaToStdString(jni, username); 391 server.username = JavaToStdString(jni, username);
382 server.password = JavaToStdString(jni, password); 392 server.password = JavaToStdString(jni, password);
383 server.tls_cert_policy = tls_cert_policy; 393 server.tls_cert_policy = tls_cert_policy;
384 server.hostname = JavaToStdString(jni, hostname); 394 server.hostname = JavaToStdString(jni, hostname);
385 server.tls_alpn_protocols = JavaToStdVectorStrings(jni, tls_alpn_protocols); 395 server.tls_alpn_protocols = JavaToStdVectorStrings(jni, tls_alpn_protocols);
386 ice_servers->push_back(server); 396 ice_servers->push_back(server);
387 } 397 }
388 } 398 }
389 399
390 void JavaToNativeRTCConfiguration( 400 void JavaToNativeRTCConfiguration(
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
697 jboolean added = jni->CallBooleanMethod(j_codecs, codecs_add, j_codec); 707 jboolean added = jni->CallBooleanMethod(j_codecs, codecs_add, j_codec);
698 CHECK_EXCEPTION(jni) << "error during CallBooleanMethod"; 708 CHECK_EXCEPTION(jni) << "error during CallBooleanMethod";
699 RTC_CHECK(added); 709 RTC_CHECK(added);
700 } 710 }
701 711
702 return j_parameters; 712 return j_parameters;
703 } 713 }
704 714
705 } // namespace jni 715 } // namespace jni
706 } // namespace webrtc 716 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698