webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.h - Issue 3012243002: Change ForwardErrorCorrection class to accept one received packet at a time.

Unified Diff: webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.h

Issue 3012243002: Change ForwardErrorCorrection class to accept one received packet at a time. (Closed)

Patch Set: Fix compilation errors, including tests. Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.h

diff --git a/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.h b/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.h

index e4f71ffb71b67d9f00fdadb22eb4a4c77098ccfd..79bcceb2311c1880364bcd5d65ba16919bbb49cf 100644

--- a/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.h

+++ b/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.h

@@ -44,7 +44,11 @@ class UlpfecReceiverImpl : public UlpfecReceiver {

// TODO(holmer): In the current version |received_packets_| is never more

// than one packet, since we process FEC every time a new packet

// arrives. We should remove the list.

- ForwardErrorCorrection::ReceivedPacketList received_packets_;

+ // TODO(nisse): But it looks like

+ // UlpfecReceiverImpl::AddReceivedRedPacket may add two packets to

brandtr 2017/09/14 11:49:45 Right, I forgot about that! I guess it can be repl

nisse-webrtc 2017/09/14 12:55:51 Things may get easier if we merge the Add...Packet

brandtr 2017/09/14 13:14:15 In Flexfec, outside users call FlexfecReceiver::On

+ // the list.

+ std::vector<std::unique_ptr<ForwardErrorCorrection::ReceivedPacket>>

+ received_packets_;

ForwardErrorCorrection::RecoveredPacketList recovered_packets_;

FecPacketCounter packet_counter_;

};