Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: modules/rtp_rtcp/source/ulpfec_receiver_impl.h

Issue 3012243002: Change ForwardErrorCorrection class to accept one received packet at a time. (Closed)
Patch Set: Rebase after The Great Move. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: modules/rtp_rtcp/source/ulpfec_receiver_impl.h
diff --git a/modules/rtp_rtcp/source/ulpfec_receiver_impl.h b/modules/rtp_rtcp/source/ulpfec_receiver_impl.h
index 8a82ec0ae175848498335d79802abdc4992ee20d..09e572861353264083bdcfc61d9f29b7869c67a2 100644
--- a/modules/rtp_rtcp/source/ulpfec_receiver_impl.h
+++ b/modules/rtp_rtcp/source/ulpfec_receiver_impl.h
@@ -12,6 +12,7 @@
#define MODULES_RTP_RTCP_SOURCE_ULPFEC_RECEIVER_IMPL_H_
#include <memory>
+#include <vector>
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "modules/rtp_rtcp/include/ulpfec_receiver.h"
@@ -44,7 +45,11 @@ class UlpfecReceiverImpl : public UlpfecReceiver {
// TODO(holmer): In the current version |received_packets_| is never more
// than one packet, since we process FEC every time a new packet
// arrives. We should remove the list.
- ForwardErrorCorrection::ReceivedPacketList received_packets_;
+ // TODO(nisse): But it looks like
stefan-webrtc 2017/09/15 13:36:13 Please update the existing TODO instead if it's no
stefan-webrtc 2017/09/15 13:36:13 Please update the existing TODO instead if it's no
nisse-webrtc 2017/09/18 12:39:06 Done.
+ // UlpfecReceiverImpl::AddReceivedRedPacket may add two packets to
+ // the list.
+ std::vector<std::unique_ptr<ForwardErrorCorrection::ReceivedPacket>>
+ received_packets_;
ForwardErrorCorrection::RecoveredPacketList recovered_packets_;
FecPacketCounter packet_counter_;
};

Powered by Google App Engine
This is Rietveld 408576698