Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: PRESUBMIT.py

Issue 3012083002: Removing deleted file from PRESUBMIT.py (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 20 matching lines...) Expand all
31 'webrtc/p2p', 31 'webrtc/p2p',
32 'webrtc/pc', 32 'webrtc/pc',
33 'webrtc/rtc_base', 33 'webrtc/rtc_base',
34 'webrtc/sdk/android/src/jni', 34 'webrtc/sdk/android/src/jni',
35 'webrtc/sdk/objc', 35 'webrtc/sdk/objc',
36 'webrtc/system_wrappers', 36 'webrtc/system_wrappers',
37 'webrtc/test', 37 'webrtc/test',
38 'webrtc/voice_engine', 38 'webrtc/voice_engine',
39 'webrtc/common_types.h', 39 'webrtc/common_types.h',
40 'webrtc/common_types.cc', 40 'webrtc/common_types.cc',
41 'webrtc/video_send_stream.h',
42 ] 41 ]
43 42
44 # These filters will always be removed, even if the caller specifies a filter 43 # These filters will always be removed, even if the caller specifies a filter
45 # set, as they are problematic or broken in some way. 44 # set, as they are problematic or broken in some way.
46 # 45 #
47 # Justifications for each filter: 46 # Justifications for each filter:
48 # - build/c++11 : Rvalue ref checks are unreliable (false positives), 47 # - build/c++11 : Rvalue ref checks are unreliable (false positives),
49 # include file and feature blacklists are 48 # include file and feature blacklists are
50 # google3-specific. 49 # google3-specific.
51 # - whitespace/operators: Same as above (doesn't seem sufficient to eliminate 50 # - whitespace/operators: Same as above (doesn't seem sufficient to eliminate
(...skipping 587 matching lines...) Expand 10 before | Expand all | Expand 10 after
639 results = [] 638 results = []
640 source_file_filter = lambda x: input_api.FilterSourceFile( 639 source_file_filter = lambda x: input_api.FilterSourceFile(
641 x, white_list=(r'.+\.proto$',)) 640 x, white_list=(r'.+\.proto$',))
642 for f in input_api.AffectedSourceFiles(source_file_filter): 641 for f in input_api.AffectedSourceFiles(source_file_filter):
643 file_path = f.LocalPath() 642 file_path = f.LocalPath()
644 with open(file_path) as f: 643 with open(file_path) as f:
645 lines = f.readlines() 644 lines = f.readlines()
646 if lines[-1] != '\n' or lines[-2] == '\n': 645 if lines[-1] != '\n' or lines[-2] == '\n':
647 results.append(output_api.PresubmitError(error_msg.format(file_path))) 646 results.append(output_api.PresubmitError(error_msg.format(file_path)))
648 return results 647 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698