Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 3011963002: Remove backwards compatibilty header for Optional (Closed)

Created:
3 years, 3 months ago by kwiberg-webrtc
Modified:
3 years, 3 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove backwards compatibilty header for Optional BUG=webrtc:8205 Review-Url: https://codereview.webrtc.org/3011963002 Cr-Commit-Position: refs/heads/master@{#19906} Committed: https://webrtc.googlesource.com/src/+/feeb9bfe033daf9976819081a191f63d5d5f5346

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
D rtc_base/optional.h View 1 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
kwiberg-webrtc
Obviously, I need to post a deprecation notice before landing this.
3 years, 3 months ago (2017-09-06 10:33:33 UTC) #6
mbonadei
On 2017/09/06 10:33:33, kwiberg-webrtc wrote: > Obviously, I need to post a deprecation notice before ...
3 years, 3 months ago (2017-09-06 11:11:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011963002/40001
3 years, 3 months ago (2017-09-20 18:48:50 UTC) #14
commit-bot: I haz the power
3 years, 3 months ago (2017-09-20 19:17:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://webrtc.googlesource.com/src/+/feeb9bfe033daf9976819081a191f63d5d5f5346

Powered by Google App Engine
This is Rietveld 408576698