Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h

Issue 3011623002: Add new ANA stats to GetStats() to count the number of actions taken by each controller. (Closed)
Patch Set: Addressed review comments. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h b/webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h
index 6d03730a1738d6262207c084e27a54a403b62f41..5b89123720a9631ca1be60a75bcff073c98bb924 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h
@@ -11,6 +11,7 @@
#ifndef WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_INCLUDE_AUDIO_NETWORK_ADAPTOR_H_
#define WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_INCLUDE_AUDIO_NETWORK_ADAPTOR_H_
+#include "webrtc/common_types.h"
#include "webrtc/rtc_base/optional.h"
namespace webrtc {
@@ -38,6 +39,16 @@ struct AudioEncoderRuntimeConfig {
// encoder based on network metrics.
class AudioNetworkAdaptor {
public:
+ struct AudioNetworkAdaptorStats {
+ AudioNetworkAdaptorStats();
+ AudioNetworkAdaptorStats(const AudioNetworkAdaptorStats&);
+ ~AudioNetworkAdaptorStats();
hbos 2017/09/04 08:49:54 Style-guide thing or can we remove these default c
ivoc 2017/09/04 15:48:03 The optionals made the class "too complex" not to
+ rtc::Optional<int> ana_bitrate_action_counter;
+ rtc::Optional<int> ana_channel_action_counter;
+ rtc::Optional<int> ana_dtx_action_counter;
+ rtc::Optional<int> ana_fec_action_counter;
+ rtc::Optional<int> ana_frame_length_action_counter;
hbos 2017/09/04 08:49:54 Is there a reason for not reusing ANAStats, either
ossu 2017/09/04 11:23:02 I agree we should try to reuse the ANAStats struct
ivoc 2017/09/04 15:48:05 Agreed, removed.
+ };
virtual ~AudioNetworkAdaptor() = default;
@@ -60,6 +71,8 @@ class AudioNetworkAdaptor {
virtual void StartDebugDump(FILE* file_handle) = 0;
virtual void StopDebugDump() = 0;
+
+ virtual ANAStats GetStats() const = 0;
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698