Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

Issue 3011623002: Add new ANA stats to GetStats() to count the number of actions taken by each controller. (Closed)
Patch Set: Fix for failing test. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
index 191493956632ed951e4d8e4df1d1d70370b1d8f5..c29b1e8c17be154bb2d00b71eaf8c49247d4cedf 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
@@ -270,4 +270,36 @@ TEST(AudioNetworkAdaptorImplTest, LogRuntimeConfigOnGetEncoderRuntimeConfig) {
states.audio_network_adaptor->GetEncoderRuntimeConfig();
}
+TEST(AudioNetworkAdaptorImplTest, TestANAStats) {
+ auto states = CreateAudioNetworkAdaptor();
+
+ // Simulate some adaptation, otherwise the stats will not show anything.
+ AudioEncoderRuntimeConfig config1, config2;
+ config1.bitrate_bps = rtc::Optional<int>(32000);
+ config1.enable_fec = rtc::Optional<bool>(true);
+ config2.bitrate_bps = rtc::Optional<int>(16000);
+ config2.enable_fec = rtc::Optional<bool>(false);
+
+ EXPECT_CALL(*states.mock_controllers[0], MakeDecision(_))
+ .WillOnce(SetArgPointee<0>(config1));
+ states.audio_network_adaptor->GetEncoderRuntimeConfig();
+ EXPECT_CALL(*states.mock_controllers[0], MakeDecision(_))
+ .WillOnce(SetArgPointee<0>(config2));
+ states.audio_network_adaptor->GetEncoderRuntimeConfig();
+
+ auto ana_stats = states.audio_network_adaptor->GetStats();
+
+ // Check that the default stats are returned, as these have not been
+ // implemented yet). Tracking bug: https://crbug.com/8127
+ auto default_stats = ANAStats();
+ EXPECT_EQ(ana_stats.bitrate_action_counter,
+ default_stats.bitrate_action_counter);
+ EXPECT_EQ(ana_stats.channel_action_counter,
+ default_stats.channel_action_counter);
+ EXPECT_EQ(ana_stats.dtx_action_counter, default_stats.dtx_action_counter);
+ EXPECT_EQ(ana_stats.fec_action_counter, default_stats.fec_action_counter);
+ EXPECT_EQ(ana_stats.frame_length_action_counter,
+ default_stats.frame_length_action_counter);
+}
+
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698