OLD | NEW |
---|---|
1 /* | 1 /* |
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. | 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
3 * | 3 * |
4 * Use of this source code is governed by a BSD-style license | 4 * Use of this source code is governed by a BSD-style license |
5 * that can be found in the LICENSE file in the root of the source | 5 * that can be found in the LICENSE file in the root of the source |
6 * tree. An additional intellectual property rights grant can be found | 6 * tree. An additional intellectual property rights grant can be found |
7 * in the file PATENTS. All contributing project authors may | 7 * in the file PATENTS. All contributing project authors may |
8 * be found in the AUTHORS file in the root of the source tree. | 8 * be found in the AUTHORS file in the root of the source tree. |
9 */ | 9 */ |
10 | 10 |
(...skipping 805 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
816 // to the time this API is called) will not be included in the list. | 816 // to the time this API is called) will not be included in the list. |
817 // | 817 // |
818 // Negative |round_trip_time_ms| results is an error message and empty list | 818 // Negative |round_trip_time_ms| results is an error message and empty list |
819 // is returned. | 819 // is returned. |
820 // | 820 // |
821 virtual std::vector<uint16_t> GetNackList( | 821 virtual std::vector<uint16_t> GetNackList( |
822 int64_t round_trip_time_ms) const = 0; | 822 int64_t round_trip_time_ms) const = 0; |
823 | 823 |
824 virtual void GetDecodingCallStatistics( | 824 virtual void GetDecodingCallStatistics( |
825 AudioDecodingCallStats* call_stats) const = 0; | 825 AudioDecodingCallStats* call_stats) const = 0; |
826 | |
827 virtual AudioEncoder::AudioEncoderStats GetAudioEncoderStatistics() const = 0; | |
minyue-webrtc
2017/08/31 07:24:21
I think it is better to do similar to GetDecodingC
ossu
2017/08/31 13:13:10
Why do you think so? Functions with output paramet
minyue-webrtc
2017/08/31 13:20:17
Copying is fine with me, and I understand the meri
ivoc
2017/08/31 14:57:50
I agree with ossu on return values vs passing poin
ivoc
2017/09/01 15:27:16
I moved the stats struct to common_types.h.
| |
826 }; | 828 }; |
827 | 829 |
828 } // namespace webrtc | 830 } // namespace webrtc |
829 | 831 |
830 #endif // WEBRTC_MODULES_AUDIO_CODING_INCLUDE_AUDIO_CODING_MODULE_H_ | 832 #endif // WEBRTC_MODULES_AUDIO_CODING_INCLUDE_AUDIO_CODING_MODULE_H_ |
OLD | NEW |