Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Issue 3011343002: Add some slice titles to ChromeUserFriendlyCategoryDriver. (Closed)

Created:
3 years, 3 months ago by benjhayden
Modified:
3 years, 2 months ago
Reviewers:
dproy, fmeawad
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add some slice titles to ChromeUserFriendlyCategoryDriver. See the sorted list of slice titles in the bug. This CL deliberately does not categorize non-specific slice titles such as TaskQueueManager::*, TimerBase::run, SyncChannel::Send. If those slices are at the bottom of the stack, then either more tracing categories should have been collected, or some parts of chromium are under-traced, and somebody should add more trace events to better cover the timeline. BUG=catapult:#3864 Review-Url: https://chromiumcodereview.appspot.com/3011343002 Committed: https://chromium.googlesource.com/catapult/+/6f7a0ba3a99702a8a6a6a86434f5b604ffa74c30

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -18 lines) Patch
M tracing/tracing/extras/chrome/chrome_user_friendly_category_driver.html View 5 chunks +67 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
benjhayden
3 years, 3 months ago (2017-09-19 07:09:52 UTC) #4
dproy
On 2017/09/19 07:09:52, benjhayden wrote: lgtm. Thanks a lot for this!
3 years, 3 months ago (2017-09-19 07:21:03 UTC) #5
fmeawad
lgtm
3 years, 2 months ago (2017-09-27 21:31:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3011343002/20001
3 years, 2 months ago (2017-09-27 21:39:48 UTC) #8
commit-bot: I haz the power
3 years, 2 months ago (2017-09-27 22:22:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/catapult/+/6f7a0ba3a99702a8a6a6a86434f5b604...

Powered by Google App Engine
This is Rietveld 408576698