Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 3010143002: Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/logging/BUILD.gn ('k') | webrtc/logging/rtc_event_log/rtc_event_log.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 // e.g. because we are already logging or the file cannot be opened. 91 // e.g. because we are already logging or the file cannot be opened.
92 virtual bool StartLogging(const std::string& file_name, 92 virtual bool StartLogging(const std::string& file_name,
93 int64_t max_size_bytes) = 0; 93 int64_t max_size_bytes) = 0;
94 94
95 // Same as above. The RtcEventLog takes ownership of the file if the call 95 // Same as above. The RtcEventLog takes ownership of the file if the call
96 // is successful, i.e. if it returns true. 96 // is successful, i.e. if it returns true.
97 virtual bool StartLogging(rtc::PlatformFile platform_file, 97 virtual bool StartLogging(rtc::PlatformFile platform_file,
98 int64_t max_size_bytes) = 0; 98 int64_t max_size_bytes) = 0;
99 99
100 // Deprecated. Pass an explicit file size limit. 100 // Deprecated. Pass an explicit file size limit.
101 RTC_DEPRECATED bool StartLogging(const std::string& file_name) { 101 bool StartLogging(const std::string& file_name) {
102 return StartLogging(file_name, 10000000); 102 return StartLogging(file_name, 10000000);
103 } 103 }
104 104
105 // Deprecated. Pass an explicit file size limit. 105 // Deprecated. Pass an explicit file size limit.
106 RTC_DEPRECATED bool StartLogging(rtc::PlatformFile platform_file) { 106 bool StartLogging(rtc::PlatformFile platform_file) {
107 return StartLogging(platform_file, 10000000); 107 return StartLogging(platform_file, 10000000);
108 } 108 }
109 109
110 // Stops logging to file and waits until the file has been closed, after 110 // Stops logging to file and waits until the thread has finished.
111 // which it would be permissible to read and/or modify it.
112 virtual void StopLogging() = 0; 111 virtual void StopLogging() = 0;
113 112
114 // Logs configuration information for a video receive stream. 113 // Logs configuration information for a video receive stream.
115 virtual void LogVideoReceiveStreamConfig( 114 virtual void LogVideoReceiveStreamConfig(
116 const rtclog::StreamConfig& config) = 0; 115 const rtclog::StreamConfig& config) = 0;
117 116
118 // Logs configuration information for a video send stream. 117 // Logs configuration information for a video send stream.
119 virtual void LogVideoSendStreamConfig(const rtclog::StreamConfig& config) = 0; 118 virtual void LogVideoSendStreamConfig(const rtclog::StreamConfig& config) = 0;
120 119
121 // Logs configuration information for an audio receive stream. 120 // Logs configuration information for an audio receive stream.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 int min_probes, 223 int min_probes,
225 int min_bytes) override{}; 224 int min_bytes) override{};
226 void LogProbeResultSuccess(int id, int bitrate_bps) override{}; 225 void LogProbeResultSuccess(int id, int bitrate_bps) override{};
227 void LogProbeResultFailure(int id, 226 void LogProbeResultFailure(int id,
228 ProbeFailureReason failure_reason) override{}; 227 ProbeFailureReason failure_reason) override{};
229 }; 228 };
230 229
231 } // namespace webrtc 230 } // namespace webrtc
232 231
233 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 232 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
OLDNEW
« no previous file with comments | « webrtc/logging/BUILD.gn ('k') | webrtc/logging/rtc_event_log/rtc_event_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698