Tightening visibility and removing a public_dep.

webrtc/test/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 import("//build/config/ui.gni")
@@ skipping 95 matching lines @@
   deps = [
     "..:webrtc_common",
     "../system_wrappers",
     "../system_wrappers:field_trial_default",
   ]
 }
 
 if (is_ios) {
   rtc_source_set("test_support_objc") {
     testonly = true
-    visibility = [ ":*" ]
+    visibility = [ ":test_support" ]
     sources = [
       "ios/test_support.h",
       "ios/test_support.mm",
     ]
   }
 }
 
 rtc_source_set("test_support") {
   testonly = true
 
@@ skipping 215 matching lines @@
       "../modules/video_capture",
       "../rtc_base:rtc_base_approved",
       "//testing/gmock",
       "//testing/gtest",
     ]
   }
 }
 
 if (is_ios) {
   rtc_source_set("fileutils_objc") {
-    visibility = [ ":*" ]
+    visibility = [ ":fileutils" ]
     sources = [
       "testsupport/iosfileutils.mm",
     ]
     deps = [
       "..:webrtc_common",
       "../rtc_base:rtc_base_approved",
       "../sdk:common_objc",
     ]
   }
 }
 
 rtc_source_set("fileutils") {
   testonly = true
-  visibility = [ ":*" ]
+  visibility = [
+    ":fileutils_unittests",
+    ":test_support_test_output",
+    ":test_support",
+    ":video_test_support",
+  ]
   sources = [
     "testsupport/fileutils.cc",
     "testsupport/fileutils.h",
   ]
   deps = [
     "..:webrtc_common",
     "../rtc_base:rtc_base_approved",
   ]
   if (is_ios) {
     deps += [ ":fileutils_objc" ]
@@ skipping 10 matching lines @@
       ":run_test_objc",
     ]
   } else {
     public_deps = [
       ":run_test_generic",
     ]
   }
 }
 
 rtc_source_set("run_test_interface") {
-  testonly = true
-  visibility = [ ":*" ]
   sources = [
     "run_test.h",
   ]
 }
 
 if (is_mac) {
   rtc_source_set("run_test_objc") {
     testonly = true
-    visibility = [ ":*" ]
+    visibility = [ ":run_test" ]
     sources = [
       "mac/run_test.mm",
     ]
-    public_deps = [
+    deps = [
       ":run_test_interface",
     ]
   }
 }
 
 rtc_source_set("run_test_generic") {
   testonly = true
-  visibility = [ ":*" ]
+  visibility = [ ":run_test" ]
   sources = [
     "run_test.cc",
   ]
-  public_deps = [
+  deps = [
     ":run_test_interface",
   ]
 }
 
 rtc_source_set("fileutils_unittests") {
   testonly = true
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
   sources = [
     "testsupport/fileutils_unittest.cc",
   ]
@@ skipping 152 matching lines @@
     # come from a config and cannot be on the target directly.
     cflags = [
       "-Wno-bool-conversion",
       "-Wno-comment",
       "-Wno-delete-non-virtual-dtor",
     ]
   }
 }
 
 rtc_source_set("test_renderer") {
+  public_deps = [
+    ":test_renderer_generic",
+  ]
   testonly = true
   if (is_mac) {
-    public_deps = [
-      ":test_renderer_objc",
-    ]
-  } else {
-    public_deps = [
-      ":test_renderer_generic",
-    ]
+    public_deps += [ ":test_renderer_objc" ]
   }
 }
 
 if (is_mac) {
   rtc_source_set("test_renderer_objc") {
     testonly = true
-    visibility = [ ":*" ]
+    visibility = [ ":test_renderer" ]
     sources = [
       "mac/video_renderer_mac.h",
       "mac/video_renderer_mac.mm",
     ]
-    public_deps = [
+    deps = [
       ":test_renderer_generic",
-    ]
-    deps = [
       "../rtc_base:rtc_base_approved",
     ]
     libs = [
       "Cocoa.framework",
       "OpenGL.framework",
       "CoreVideo.framework",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }
 
 rtc_source_set("test_renderer_generic") {
   testonly = true
-  visibility = [ ":*" ]
+  visibility = [
+    ":test_renderer",
+    ":test_renderer_objc",
+  ]
   libs = []
   sources = [
     "linux/glx_renderer.cc",
     "linux/glx_renderer.h",
     "linux/video_renderer_linux.cc",
     "video_renderer.cc",
     "video_renderer.h",
     "win/d3d_renderer.cc",
     "win/d3d_renderer.h",
   ]
@@ skipping 67 matching lines @@
     ]
     deps = [
       "../rtc_base:base_java",
       "//testing/android/native_test:native_test_java",
     ]
 
     # TODO(sakal): Fix build hooks crbug.com/webrtc/8148
     no_build_hooks = true
   }
 }