webrtc/rtc_base/task_queue.h - Issue 3009763002: Prove TaskQueue issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/rtc_base/task_queue.h

Issue 3009763002: Prove TaskQueue issue

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/rtc_base/task_queue.h

diff --git a/webrtc/rtc_base/task_queue.h b/webrtc/rtc_base/task_queue.h

index 218fce9a3b9854529e5683731915b13324aaea25..aaad493494039cf01dd28422025558d366000a69 100644

--- a/webrtc/rtc_base/task_queue.h

+++ b/webrtc/rtc_base/task_queue.h

@@ -154,6 +154,7 @@ static std::unique_ptr<QueuedTask> NewClosure(const Closure& closure,

// A note on destruction:

+// The first sentence here is in contradiction with the current implementation:

// When a TaskQueue is deleted, pending tasks will not be executed but they will

// be deleted. The deletion of tasks may happen asynchronously after the

// TaskQueue itself has been deleted or it may happen synchronously while the

« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc ('k') | no next file » | no next file with comments »