Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: webrtc/rtc_base/task_queue.h

Issue 3009133002: Convert windows TaskQueue implementation to pimpl convention. (Closed)
Patch Set: Fix ThreadMain, and add PostTask template. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/rtc_base/task_queue_win.cc » ('j') | webrtc/rtc_base/task_queue_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_base/task_queue.h
diff --git a/webrtc/rtc_base/task_queue.h b/webrtc/rtc_base/task_queue.h
index 5dee6e613d2e249e6a82388b3e181570507623bc..966b29c40d0c1dc54fa76b6da509003a27a121e2 100644
--- a/webrtc/rtc_base/task_queue.h
+++ b/webrtc/rtc_base/task_queue.h
@@ -24,10 +24,6 @@
#include "webrtc/rtc_base/criticalsection.h"
#include "webrtc/rtc_base/scoped_ref_ptr.h"
-#if defined(WEBRTC_WIN)
-#include "webrtc/rtc_base/platform_thread.h"
-#endif
-
namespace rtc {
// Base interface for asynchronously executed tasks.
@@ -246,27 +242,6 @@ class LOCKABLE TaskQueue {
struct PostTaskAndReplyContext;
dispatch_queue_t queue_;
QueueContext* const context_;
-#elif defined(WEBRTC_WIN)
- class ThreadState;
- void RunPendingTasks();
- static void ThreadMain(void* context);
-
- class WorkerThread : public PlatformThread {
- public:
- WorkerThread(ThreadRunFunction func,
- void* obj,
- const char* thread_name,
- ThreadPriority priority)
- : PlatformThread(func, obj, thread_name, priority) {}
-
- bool QueueAPC(PAPCFUNC apc_function, ULONG_PTR data) {
- return PlatformThread::QueueAPC(apc_function, data);
- }
- };
- WorkerThread thread_;
- rtc::CriticalSection pending_lock_;
- std::queue<std::unique_ptr<QueuedTask>> pending_ GUARDED_BY(pending_lock_);
- HANDLE in_queue_;
#else
class Impl;
const scoped_refptr<Impl> impl_;
« no previous file with comments | « no previous file | webrtc/rtc_base/task_queue_win.cc » ('j') | webrtc/rtc_base/task_queue_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698