Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: webrtc/rtc_base/random_unittest.cc

Issue 3009123002: Move UBSan warnings from a blacklist to the source (Closed)
Patch Set: Address review comments Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/rtc_base/random.cc ('k') | webrtc/rtc_base/sanitizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_base/random_unittest.cc
diff --git a/webrtc/rtc_base/random_unittest.cc b/webrtc/rtc_base/random_unittest.cc
index 0af2733faaca1c2bfa625ad9c3258077dee3d34a..12d17ad3404e609efed9d51b369fbd3e1076210f 100644
--- a/webrtc/rtc_base/random_unittest.cc
+++ b/webrtc/rtc_base/random_unittest.cc
@@ -199,13 +199,7 @@ TEST(RandomNumberGeneratorTest, UniformUnsignedInterval) {
BucketTestUnsignedInterval(1000, 1000000, 0, 2147483999, 4, &prng);
}
-// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5491
-#ifdef UNDEFINED_SANITIZER
-#define MAYBE_UniformSignedInterval DISABLED_UniformSignedInterval
-#else
-#define MAYBE_UniformSignedInterval UniformSignedInterval
-#endif
-TEST(RandomNumberGeneratorTest, MAYBE_UniformSignedInterval) {
+TEST(RandomNumberGeneratorTest, UniformSignedInterval) {
Random prng(66260695729ull);
BucketTestSignedInterval(2, 100000, 0, 1, 3, &prng);
BucketTestSignedInterval(7, 100000, -2, 4, 3, &prng);
« no previous file with comments | « webrtc/rtc_base/random.cc ('k') | webrtc/rtc_base/sanitizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698