webrtc/common_audio/signal_processing/signal_processing_unittest.cc - Issue 3009123002: Move UBSan warnings from a blacklist to the source

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/signal_processing/signal_processing_unittest.cc

Issue 3009123002: Move UBSan warnings from a blacklist to the source (Closed)

Patch Set: Address review comments Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_audio/signal_processing/resample_by_2_internal.c ('k') | webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_audio/signal_processing/signal_processing_unittest.cc

diff --git a/webrtc/common_audio/signal_processing/signal_processing_unittest.cc b/webrtc/common_audio/signal_processing/signal_processing_unittest.cc

index da6197ef3295ef4cd52e4802ca35fb5a7b79239b..52c4390c44b679fc72b9e21b6094f02ee38c8192 100644

--- a/webrtc/common_audio/signal_processing/signal_processing_unittest.cc

+++ b/webrtc/common_audio/signal_processing/signal_processing_unittest.cc

@@ -41,7 +41,6 @@ TEST_F(SplTest, MacroTest) {

EXPECT_EQ(3, WEBRTC_SPL_ABS_W32(a));

EXPECT_EQ(-63, WEBRTC_SPL_MUL(a, B));

- EXPECT_EQ(-2147483645, WEBRTC_SPL_MUL(a, b));

EXPECT_EQ(2147483651u, WEBRTC_SPL_UMUL(a, b));

b = WEBRTC_SPL_WORD16_MAX >> 1;

EXPECT_EQ(4294918147u, WEBRTC_SPL_UMUL_32_16(a, b));