Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: tools_webrtc/ubsan/blacklist.txt

Issue 3009123002: Move UBSan warnings from a blacklist to the source (Closed)
Patch Set: Address review comments Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/common_audio/signal_processing/division_operations.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools_webrtc/ubsan/blacklist.txt
diff --git a/tools_webrtc/ubsan/blacklist.txt b/tools_webrtc/ubsan/blacklist.txt
index a65b1600c412f145a9788a7fff56d49226c05793..3f4c80ec1bd16c92c581b702ebdc3be4e172f099 100644
--- a/tools_webrtc/ubsan/blacklist.txt
+++ b/tools_webrtc/ubsan/blacklist.txt
@@ -1,9 +1,9 @@
#############################################################################
# UBSan blacklist.
-# Please think twice before you add or remove these rules.
-
-# This is a stripped down copy of Chromium's blacklist.txt, to enable
-# adding WebRTC-specific blacklist entries.
+#
+# This is a WebRTC-specific replacement of Chromium's blacklist.txt.
+# Only exceptions for third party libraries go here. WebRTC's code should use
+# the RTC_NO_SANITIZE macro. Please think twice before adding new exceptions.
#############################################################################
# YASM does some funny things that UBsan doesn't like.
@@ -17,22 +17,3 @@ src:*/third_party/openh264/*
#############################################################################
# Ignore system libraries.
src:*/usr/*
-
-#############################################################################
-# https://bugs.chromium.org/p/webrtc/issues/detail?id=5513
-fun:*FilterBanksTest*CalculateResidualEnergyTester*
-
-#############################################################################
-# https://bugs.chromium.org/p/webrtc/issues/detail?id=8200
-fun:*WebRtcAecm_ProcessBlock*
-
-#############################################################################
-# Ignore errors in common_audio.
-# https://bugs.chromium.org/p/webrtc/issues/detail?id=5486
-src:*/webrtc/common_audio/signal_processing/signal_processing_unittest.cc
-src:*/webrtc/common_audio/signal_processing/resample_by_2_internal.c
-fun:*WebRtcSpl_AddSatW32*
-fun:*WebRtcSpl_SubSatW32*
-fun:*WebRtcSpl_DivW32HiLow*
-fun:*WebRtcSpl_LevinsonDurbin*
-fun:*GmmProbability*
« no previous file with comments | « no previous file | webrtc/common_audio/signal_processing/division_operations.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698