webrtc/rtc_base/ipaddress_unittest.cc - Issue 3009123002: Move UBSan warnings from a blacklist to the source

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/rtc_base/ipaddress_unittest.cc

Issue 3009123002: Move UBSan warnings from a blacklist to the source (Closed)

Patch Set: Remove test that doesnt check anything useful Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/rtc_base/ipaddress_unittest.cc

diff --git a/webrtc/rtc_base/ipaddress_unittest.cc b/webrtc/rtc_base/ipaddress_unittest.cc

index 3389fef0821d1586c70b6766e16a2f019b4c875d..61a067f28306b696c98f07d056134eb34fd87b50 100644

--- a/webrtc/rtc_base/ipaddress_unittest.cc

+++ b/webrtc/rtc_base/ipaddress_unittest.cc

@@ -672,13 +672,7 @@ TEST(IPAddressTest, TestAsIPv6Address) {

EXPECT_EQ(addr, addr2);

}

-// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5491

-#ifdef UNDEFINED_SANITIZER

-#define MAYBE_TestCountIPMaskBits DISABLED_TestCountIPMaskBits

-#else

-#define MAYBE_TestCountIPMaskBits TestCountIPMaskBits

-#endif

-TEST(IPAddressTest, MAYBE_TestCountIPMaskBits) {

+TEST(IPAddressTest, TestCountIPMaskBits) {

IPAddress mask;

// IPv4 on byte boundaries

EXPECT_PRED2(CheckMaskCount, "255.255.255.255", 32);