Move UBSan warnings from a blacklist to the source

webrtc/common_audio/signal_processing/resample_by_2_internal.c

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 
 /*
  * This header file contains some internal resampling functions.
  *
  */
 
 #include "webrtc/common_audio/signal_processing/resample_by_2_internal.h"
+#include "webrtc/rtc_base/sanitizer.h"
 
 // allpass filter coefficients.
 static const int16_t kResampleAllpass[2][3] = {
         {821, 6110, 12382},
         {3050, 9368, 15063}
 };
 
 //
 //   decimator
 // input:  int32_t (shifted 15 positions to the left, + offset 16384) OVERWRITTEN!
 // output: int16_t (saturated) (of length len/2)
 // state:  filter state array; length = 8
 
-void WebRtcSpl_DownBy2IntToShort(int32_t *in, int32_t len, int16_t *out,
-                                 int32_t *state)
+void RTC_NO_SANITIZE("signed-integer-overflow")  // bugs.webrtc.org/5486
+WebRtcSpl_DownBy2IntToShort(int32_t *in, int32_t len, int16_t *out,
+                            int32_t *state)
 {
     int32_t tmp0, tmp1, diff;
     int32_t i;
 
     len >>= 1;
 
     // lower allpass filter (operates on even input samples)
     for (i = 0; i < len; i++)
     {
         tmp0 = in[i << 1];
         diff = tmp0 - state[1];
+        // UBSan: -1771017321 - 999586185 cannot be represented in type 'int'
+
         // scale down and round
         diff = (diff + (1 << 13)) >> 14;
         tmp1 = state[0] + diff * kResampleAllpass[1][0];
         state[0] = tmp0;
         diff = tmp1 - state[2];
         // scale down and truncate
         diff = diff >> 14;
         if (diff < 0)
             diff += 1;
         tmp0 = state[1] + diff * kResampleAllpass[1][1];
@@ skipping 60 matching lines @@
         out[i + 1] = (int16_t)tmp1;
     }
 }
 
 //
 //   decimator
 // input:  int16_t
 // output: int32_t (shifted 15 positions to the left, + offset 16384) (of length len/2)
 // state:  filter state array; length = 8
 
-void WebRtcSpl_DownBy2ShortToInt(const int16_t *in,
-                                  int32_t len,
-                                  int32_t *out,
-                                  int32_t *state)
+void RTC_NO_SANITIZE("signed-integer-overflow")  // bugs.webrtc.org/5486
+WebRtcSpl_DownBy2ShortToInt(const int16_t *in,
+                            int32_t len,
+                            int32_t *out,
+                            int32_t *state)
 {
     int32_t tmp0, tmp1, diff;
     int32_t i;
 
     len >>= 1;
 
     // lower allpass filter (operates on even input samples)
     for (i = 0; i < len; i++)
     {
         tmp0 = ((int32_t)in[i << 1] << 15) + (1 << 14);
         diff = tmp0 - state[1];
         // scale down and round
         diff = (diff + (1 << 13)) >> 14;
         tmp1 = state[0] + diff * kResampleAllpass[1][0];
         state[0] = tmp0;
         diff = tmp1 - state[2];
+        // UBSan: -1379909682 - 834099714 cannot be represented in type 'int'
+
         // scale down and truncate
         diff = diff >> 14;
         if (diff < 0)
             diff += 1;
         tmp0 = state[1] + diff * kResampleAllpass[1][1];
         state[1] = tmp1;
         diff = tmp0 - state[3];
         // scale down and truncate
         diff = diff >> 14;
         if (diff < 0)
@@ skipping 388 matching lines @@
 
         // average the two allpass outputs, scale down and store
         out[i << 1] = (out[i << 1] + (state[15] >> 1)) >> 15;
     }
 }
 
 //   lowpass filter
 // input:  int32_t (shifted 15 positions to the left, + offset 16384)
 // output: int32_t (normalized, not saturated)
 // state:  filter state array; length = 8
-void WebRtcSpl_LPBy2IntToInt(const int32_t* in, int32_t len, int32_t* out,
-                             int32_t* state)
+void RTC_NO_SANITIZE("signed-integer-overflow")  // bugs.webrtc.org/5486
+WebRtcSpl_LPBy2IntToInt(const int32_t* in, int32_t len, int32_t* out,
+                        int32_t* state)
 {
     int32_t tmp0, tmp1, diff;
     int32_t i;
 
     len >>= 1;
 
     // lower allpass filter: odd input -> even output samples
     in++;
     // initial state of polyphase delay element
     tmp0 = state[12];
@@ skipping 23 matching lines @@
         out[i << 1] = state[3] >> 1;
         tmp0 = in[i << 1];
     }
     in--;
 
     // upper allpass filter: even input -> even output samples
     for (i = 0; i < len; i++)
     {
         tmp0 = in[i << 1];
         diff = tmp0 - state[5];
+        // UBSan: -794814117 - 1566149201 cannot be represented in type 'int'
+
         // scale down and round
         diff = (diff + (1 << 13)) >> 14;
         tmp1 = state[4] + diff * kResampleAllpass[0][0];
         state[4] = tmp0;
         diff = tmp1 - state[6];
         // scale down and round
         diff = diff >> 14;
         if (diff < 0)
             diff += 1;
         tmp0 = state[5] + diff * kResampleAllpass[0][1];
@@ skipping 63 matching lines @@
         diff = diff >> 14;
         if (diff < 0)
             diff += 1;
         state[15] = state[14] + diff * kResampleAllpass[0][2];
         state[14] = tmp0;
 
         // average the two allpass outputs, scale down and store
         out[i << 1] = (out[i << 1] + (state[15] >> 1)) >> 15;
     }
 }