tools_webrtc/ubsan/blacklist.txt - Issue 3009123002: Move UBSan warnings from a blacklist to the source

Side by Side Diff: tools_webrtc/ubsan/blacklist.txt

Issue 3009123002: Move UBSan warnings from a blacklist to the source (Closed)

Patch Set: Remove test that doesnt check anything useful Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 #############################################################################	1 #############################################################################

2 # UBSan blacklist.	2 # UBSan blacklist.

3 # Please think twice before you add or remove these rules.	3 # Please think twice before you add or remove these rules.
	kwiberg-webrtc 2017/09/04 23:09:50 Should we have an explicit warning against putting Should we have an explicit warning against putting WebRTC's own files here? That stuff you just removed... oprypin_webrtc 2017/09/05 07:27:34 Yeah I guess. Reworded this. Show quoted text On 2017/09/04 23:09:50, kwiberg-webrtc wrote: > Should we have an explicit warning against putting WebRTC's own files here? That > stuff you just removed... Yeah I guess. Reworded this. kwiberg-webrtc 2017/09/05 08:37:30 Nice. Show quoted text On 2017/09/05 07:27:34, oprypin_webrtc wrote: > On 2017/09/04 23:09:50, kwiberg-webrtc wrote: > > Should we have an explicit warning against putting WebRTC's own files here? > That > > stuff you just removed... > > Yeah I guess. Reworded this. Nice.
4	4

5 # This is a stripped down copy of Chromium's blacklist.txt, to enable	5 # This is a stripped down copy of Chromium's blacklist.txt, to enable

6 # adding WebRTC-specific blacklist entries.	6 # adding WebRTC-specific blacklist entries.
	kwiberg-webrtc 2017/09/04 23:09:50 Do we need our own copy now? Do we need our own copy now? oprypin_webrtc 2017/09/05 07:27:34 Yes. Not only do they have Chromium-specific funct Show quoted text On 2017/09/04 23:09:50, kwiberg-webrtc wrote: > Do we need our own copy now? Yes. Not only do they have Chromium-specific function blacklists, but also are missing some third_party library exceptions compared to this. https://chromium.googlesource.com/chromium/src/tools/+/master/ubsan/blacklist... kwiberg-webrtc 2017/09/05 08:37:30 Acknowledged. Show quoted text On 2017/09/05 07:27:34, oprypin_webrtc wrote: > On 2017/09/04 23:09:50, kwiberg-webrtc wrote: > > Do we need our own copy now? > > Yes. Not only do they have Chromium-specific function blacklists, but also are > missing some third_party library exceptions compared to this. > > https://chromium.googlesource.com/chromium/src/tools/+/master/ubsan/blacklist... Acknowledged.
7	7

8 #############################################################################	8 #############################################################################

9 # YASM does some funny things that UBsan doesn't like.	9 # YASM does some funny things that UBsan doesn't like.

10 # https://crbug.com/489901	10 # https://crbug.com/489901

11 src:/third_party/yasm/	11 src:/third_party/yasm/

12	12

13 # OpenH264 triggers some errors that are out of our control.	13 # OpenH264 triggers some errors that are out of our control.

14 src:/third_party/ffmpeg/libavcodec/	14 src:/third_party/ffmpeg/libavcodec/

15 src:/third_party/openh264/	15 src:/third_party/openh264/

16	16

17 #############################################################################	17 #############################################################################

18 # Ignore system libraries.	18 # Ignore system libraries.

19 src:/usr/	19 src:/usr/

20

21 #############################################################################

22 # https://bugs.chromium.org/p/webrtc/issues/detail?id=5513

23 fun:FilterBanksTestCalculateResidualEnergyTester*

24

25 #############################################################################

26 # https://bugs.chromium.org/p/webrtc/issues/detail?id=8200

27 fun:WebRtcAecm_ProcessBlock

28

29 #############################################################################

30 # Ignore errors in common_audio.

31 # https://bugs.chromium.org/p/webrtc/issues/detail?id=5486

32 src:*/webrtc/common_audio/signal_processing/signal_processing_unittest.cc

33 src:*/webrtc/common_audio/signal_processing/resample_by_2_internal.c

34 fun:WebRtcSpl_AddSatW32

35 fun:WebRtcSpl_SubSatW32

36 fun:WebRtcSpl_DivW32HiLow

37 fun:WebRtcSpl_LevinsonDurbin

38 fun:GmmProbability

OLD	NEW