Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webrtc/video/video_receive_stream.h

Issue 3008983002: Change reporting of timing frames conditions in GetStats on receive side (Closed)
Patch Set: Implement Tommi@ comments Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/receive_statistics_proxy_unittest.cc ('k') | webrtc/video/video_receive_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 bool DeliverRtcp(const uint8_t* packet, size_t length); 65 bool DeliverRtcp(const uint8_t* packet, size_t length);
66 66
67 void SetSync(Syncable* audio_syncable); 67 void SetSync(Syncable* audio_syncable);
68 68
69 // Implements webrtc::VideoReceiveStream. 69 // Implements webrtc::VideoReceiveStream.
70 void Start() override; 70 void Start() override;
71 void Stop() override; 71 void Stop() override;
72 72
73 webrtc::VideoReceiveStream::Stats GetStats() const override; 73 webrtc::VideoReceiveStream::Stats GetStats() const override;
74 74
75 rtc::Optional<TimingFrameInfo> GetAndResetTimingFrameInfo() override;
76
77 // Takes ownership of the file, is responsible for closing it later. 75 // Takes ownership of the file, is responsible for closing it later.
78 // Calling this method will close and finalize any current log. 76 // Calling this method will close and finalize any current log.
79 // Giving rtc::kInvalidPlatformFileValue disables logging. 77 // Giving rtc::kInvalidPlatformFileValue disables logging.
80 // If a frame to be written would make the log too large the write fails and 78 // If a frame to be written would make the log too large the write fails and
81 // the log is closed and finalized. A |byte_limit| of 0 means no limit. 79 // the log is closed and finalized. A |byte_limit| of 0 means no limit.
82 void EnableEncodedFrameRecording(rtc::PlatformFile file, 80 void EnableEncodedFrameRecording(rtc::PlatformFile file,
83 size_t byte_limit) override; 81 size_t byte_limit) override;
84 82
85 void AddSecondarySink(RtpPacketSinkInterface* sink) override; 83 void AddSecondarySink(RtpPacketSinkInterface* sink) override;
86 void RemoveSecondarySink(const RtpPacketSinkInterface* sink) override; 84 void RemoveSecondarySink(const RtpPacketSinkInterface* sink) override;
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 // a decoding error) we require a keyframe to restart the stream. 147 // a decoding error) we require a keyframe to restart the stream.
150 bool keyframe_required_ = true; 148 bool keyframe_required_ = true;
151 149
152 // If we have successfully decoded any frame. 150 // If we have successfully decoded any frame.
153 bool frame_decoded_ = false; 151 bool frame_decoded_ = false;
154 }; 152 };
155 } // namespace internal 153 } // namespace internal
156 } // namespace webrtc 154 } // namespace webrtc
157 155
158 #endif // WEBRTC_VIDEO_VIDEO_RECEIVE_STREAM_H_ 156 #endif // WEBRTC_VIDEO_VIDEO_RECEIVE_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/video/receive_statistics_proxy_unittest.cc ('k') | webrtc/video/video_receive_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698