Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: webrtc/call/video_receive_stream.h

Issue 3008983002: Change reporting of timing frames conditions in GetStats on receive side (Closed)
Patch Set: Implement Tommi@ comments Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/video/video_timing.cc ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 int width = 0; 87 int width = 0;
88 int height = 0; 88 int height = 0;
89 89
90 int sync_offset_ms = std::numeric_limits<int>::max(); 90 int sync_offset_ms = std::numeric_limits<int>::max();
91 91
92 uint32_t ssrc = 0; 92 uint32_t ssrc = 0;
93 std::string c_name; 93 std::string c_name;
94 StreamDataCounters rtp_stats; 94 StreamDataCounters rtp_stats;
95 RtcpPacketTypeCounter rtcp_packet_type_counts; 95 RtcpPacketTypeCounter rtcp_packet_type_counts;
96 RtcpStatistics rtcp_stats; 96 RtcpStatistics rtcp_stats;
97
98 // Timing frame info: all important timestamps for a full lifetime of a
99 // single 'timing frame'.
100 rtc::Optional<webrtc::TimingFrameInfo> timing_frame_info;
97 }; 101 };
98 102
99 struct Config { 103 struct Config {
100 private: 104 private:
101 // Access to the copy constructor is private to force use of the Copy() 105 // Access to the copy constructor is private to force use of the Copy()
102 // method for those exceptional cases where we do use it. 106 // method for those exceptional cases where we do use it.
103 Config(const Config&); 107 Config(const Config&);
104 108
105 public: 109 public:
106 Config() = delete; 110 Config() = delete;
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 // Starts stream activity. 218 // Starts stream activity.
215 // When a stream is active, it can receive, process and deliver packets. 219 // When a stream is active, it can receive, process and deliver packets.
216 virtual void Start() = 0; 220 virtual void Start() = 0;
217 // Stops stream activity. 221 // Stops stream activity.
218 // When a stream is stopped, it can't receive, process or deliver packets. 222 // When a stream is stopped, it can't receive, process or deliver packets.
219 virtual void Stop() = 0; 223 virtual void Stop() = 0;
220 224
221 // TODO(pbos): Add info on currently-received codec to Stats. 225 // TODO(pbos): Add info on currently-received codec to Stats.
222 virtual Stats GetStats() const = 0; 226 virtual Stats GetStats() const = 0;
223 227
224 virtual rtc::Optional<TimingFrameInfo> GetAndResetTimingFrameInfo() = 0;
225
226 // Takes ownership of the file, is responsible for closing it later. 228 // Takes ownership of the file, is responsible for closing it later.
227 // Calling this method will close and finalize any current log. 229 // Calling this method will close and finalize any current log.
228 // Giving rtc::kInvalidPlatformFileValue disables logging. 230 // Giving rtc::kInvalidPlatformFileValue disables logging.
229 // If a frame to be written would make the log too large the write fails and 231 // If a frame to be written would make the log too large the write fails and
230 // the log is closed and finalized. A |byte_limit| of 0 means no limit. 232 // the log is closed and finalized. A |byte_limit| of 0 means no limit.
231 virtual void EnableEncodedFrameRecording(rtc::PlatformFile file, 233 virtual void EnableEncodedFrameRecording(rtc::PlatformFile file,
232 size_t byte_limit) = 0; 234 size_t byte_limit) = 0;
233 inline void DisableEncodedFrameRecording() { 235 inline void DisableEncodedFrameRecording() {
234 EnableEncodedFrameRecording(rtc::kInvalidPlatformFileValue, 0); 236 EnableEncodedFrameRecording(rtc::kInvalidPlatformFileValue, 0);
235 } 237 }
236 238
237 // RtpDemuxer only forwards a given RTP packet to one sink. However, some 239 // RtpDemuxer only forwards a given RTP packet to one sink. However, some
238 // sinks, such as FlexFEC, might wish to be informed of all of the packets 240 // sinks, such as FlexFEC, might wish to be informed of all of the packets
239 // a given sink receives (or any set of sinks). They may do so by registering 241 // a given sink receives (or any set of sinks). They may do so by registering
240 // themselves as secondary sinks. 242 // themselves as secondary sinks.
241 virtual void AddSecondarySink(RtpPacketSinkInterface* sink) = 0; 243 virtual void AddSecondarySink(RtpPacketSinkInterface* sink) = 0;
242 virtual void RemoveSecondarySink(const RtpPacketSinkInterface* sink) = 0; 244 virtual void RemoveSecondarySink(const RtpPacketSinkInterface* sink) = 0;
243 245
244 protected: 246 protected:
245 virtual ~VideoReceiveStream() {} 247 virtual ~VideoReceiveStream() {}
246 }; 248 };
247 249
248 } // namespace webrtc 250 } // namespace webrtc
249 251
250 #endif // WEBRTC_CALL_VIDEO_RECEIVE_STREAM_H_ 252 #endif // WEBRTC_CALL_VIDEO_RECEIVE_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/api/video/video_timing.cc ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698