Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Side by Side Diff: webrtc/api/video/video_timing.h

Issue 3008983002: Change reporting of timing frames conditions in GetStats on receive side (Closed)
Patch Set: Implement Sprang@ comments Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/video/video_timing.cc » ('j') | webrtc/api/video/video_timing.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 // Returns true if flags are set to indicate this frame was marked fro tracing 82 // Returns true if flags are set to indicate this frame was marked fro tracing
83 // due to cyclic timer. 83 // due to cyclic timer.
84 bool IsTimerTriggered() const; 84 bool IsTimerTriggered() const;
85 85
86 // Returns true if the timing data is marked as invalid, in which case it 86 // Returns true if the timing data is marked as invalid, in which case it
87 // should be ignored. 87 // should be ignored.
88 bool IsInvalid() const; 88 bool IsInvalid() const;
89 89
90 std::string ToString() const; 90 std::string ToString() const;
91 91
92 bool operator<(const TimingFrameInfo& other);
tommi 2017/09/04 09:09:21 nit: should these be const?
ilnik 2017/09/04 09:18:55 Done.
93
94 bool operator<=(const TimingFrameInfo& other);
95
92 uint32_t rtp_timestamp; // Identifier of a frame. 96 uint32_t rtp_timestamp; // Identifier of a frame.
93 // All timestamps below are in local monotonous clock of a receiver. 97 // All timestamps below are in local monotonous clock of a receiver.
94 // If sender clock is not yet estimated, sender timestamps 98 // If sender clock is not yet estimated, sender timestamps
95 // (capture_time_ms ... pacer_exit_ms) are negative values, still 99 // (capture_time_ms ... pacer_exit_ms) are negative values, still
96 // relatively correct. 100 // relatively correct.
97 int64_t capture_time_ms; // Captrue time of a frame. 101 int64_t capture_time_ms; // Captrue time of a frame.
98 int64_t encode_start_ms; // Encode start time. 102 int64_t encode_start_ms; // Encode start time.
99 int64_t encode_finish_ms; // Encode completion time. 103 int64_t encode_finish_ms; // Encode completion time.
100 int64_t packetization_finish_ms; // Time when frame was passed to pacer. 104 int64_t packetization_finish_ms; // Time when frame was passed to pacer.
101 int64_t pacer_exit_ms; // Time when last packet was pushed out of pacer. 105 int64_t pacer_exit_ms; // Time when last packet was pushed out of pacer.
102 // Two in-network RTP processor timestamps: meaning is application specific. 106 // Two in-network RTP processor timestamps: meaning is application specific.
103 int64_t network_timestamp_ms; 107 int64_t network_timestamp_ms;
104 int64_t network2_timestamp_ms; 108 int64_t network2_timestamp_ms;
105 int64_t receive_start_ms; // First received packet time. 109 int64_t receive_start_ms; // First received packet time.
106 int64_t receive_finish_ms; // Last received packet time. 110 int64_t receive_finish_ms; // Last received packet time.
107 int64_t decode_start_ms; // Decode start time. 111 int64_t decode_start_ms; // Decode start time.
108 int64_t decode_finish_ms; // Decode completion time. 112 int64_t decode_finish_ms; // Decode completion time.
109 int64_t render_time_ms; // Proposed render time to insure smooth playback. 113 int64_t render_time_ms; // Proposed render time to insure smooth playback.
110 114
111 uint8_t flags; // Flags indicating validity and/or why tracing was triggered. 115 uint8_t flags; // Flags indicating validity and/or why tracing was triggered.
112 }; 116 };
113 117
114 } // namespace webrtc 118 } // namespace webrtc
115 119
116 #endif // WEBRTC_API_VIDEO_VIDEO_TIMING_H_ 120 #endif // WEBRTC_API_VIDEO_VIDEO_TIMING_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/video/video_timing.cc » ('j') | webrtc/api/video/video_timing.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698