Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: webrtc/call/video_receive_stream.h

Issue 3008773002: Use RtxReceiveStream. (Closed)
Patch Set: Improve TODO comments. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 // See draft-alvestrand-rmcat-remb for information. 153 // See draft-alvestrand-rmcat-remb for information.
154 bool remb = false; 154 bool remb = false;
155 155
156 // See draft-holmer-rmcat-transport-wide-cc-extensions for details. 156 // See draft-holmer-rmcat-transport-wide-cc-extensions for details.
157 bool transport_cc = false; 157 bool transport_cc = false;
158 158
159 // See NackConfig for description. 159 // See NackConfig for description.
160 NackConfig nack; 160 NackConfig nack;
161 161
162 // See UlpfecConfig for description. 162 // See UlpfecConfig for description.
163 // TODO(nisse): UlpfecConfig includes the field red_rtx_payload_type,
164 // which duplicates info in the rtx_associated_payload_types mapping. So
165 // delete the use of UlpfecConfig here, and replace by the values which
166 // make sense in this context, likely those are ulpfec_payload_type_ and
167 // red_payload_type_.
163 UlpfecConfig ulpfec; 168 UlpfecConfig ulpfec;
164 169
165 // SSRC for retransmissions. 170 // SSRC for retransmissions.
166 uint32_t rtx_ssrc = 0; 171 uint32_t rtx_ssrc = 0;
167 172
168 // Set if the stream is protected using FlexFEC. 173 // Set if the stream is protected using FlexFEC.
169 bool protected_by_flexfec = false; 174 bool protected_by_flexfec = false;
170 175
171 // Map from rtx payload type -> media payload type. 176 // Map from rtx payload type -> media payload type.
172 // For RTX to be enabled, both an SSRC and this mapping are needed. 177 // For RTX to be enabled, both an SSRC and this mapping are needed.
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 virtual void AddSecondarySink(RtpPacketSinkInterface* sink) = 0; 246 virtual void AddSecondarySink(RtpPacketSinkInterface* sink) = 0;
242 virtual void RemoveSecondarySink(const RtpPacketSinkInterface* sink) = 0; 247 virtual void RemoveSecondarySink(const RtpPacketSinkInterface* sink) = 0;
243 248
244 protected: 249 protected:
245 virtual ~VideoReceiveStream() {} 250 virtual ~VideoReceiveStream() {}
246 }; 251 };
247 252
248 } // namespace webrtc 253 } // namespace webrtc
249 254
250 #endif // WEBRTC_CALL_VIDEO_RECEIVE_STREAM_H_ 255 #endif // WEBRTC_CALL_VIDEO_RECEIVE_STREAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698