Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: webrtc/test/call_test.cc

Issue 3008273002: Replace voe_conference_test. (Closed)
Patch Set: rebase Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/test/call_test.cc
diff --git a/webrtc/test/call_test.cc b/webrtc/test/call_test.cc
index b5d7236a65181350001d518ddb7ae8b8b0c538ff..0d2dcb60c7919a9f822bb312feb74e861632ad22 100644
--- a/webrtc/test/call_test.cc
+++ b/webrtc/test/call_test.cc
@@ -153,8 +153,9 @@ void CallTest::RunBaseTest(BaseTest* test) {
test->PerformTest();
- task_queue_.SendTask([this]() {
+ task_queue_.SendTask([this, test]() {
kwiberg-webrtc 2017/09/13 14:20:26 The lambda is capturing test by value, i.e. making
the sun 2017/09/13 14:53:33 test is a pointer and CallTest owns the TQ, so thi
kwiberg-webrtc 2017/09/14 01:26:40 Acknowledged.
Stop();
+ test->OnStreamsStopped();
DestroyStreams();
send_transport_.reset();
receive_transport_.reset();
@@ -162,8 +163,6 @@ void CallTest::RunBaseTest(BaseTest* test) {
if (num_audio_streams_ > 0)
DestroyVoiceEngines();
});
-
- test->OnTestFinished();
}
void CallTest::CreateCalls(const Call::Config& sender_config,
@@ -590,7 +589,7 @@ void BaseTest::OnFrameGeneratorCapturerCreated(
FrameGeneratorCapturer* frame_generator_capturer) {
}
-void BaseTest::OnTestFinished() {
+void BaseTest::OnStreamsStopped() {
}
SendTest::SendTest(unsigned int timeout_ms) : BaseTest(timeout_ms) {

Powered by Google App Engine
This is Rietveld 408576698