Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: webrtc/rtc_base/thread_annotations_unittest.cc

Issue 3008193002: Revert of Rename thread annotation macros to have RTC prefix for syncrhonization primitives. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/rtc_base/thread_annotations.h ('k') | webrtc/rtc_base/thread_checker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/rtc_base/thread_annotations.h" 11 #include "webrtc/rtc_base/thread_annotations.h"
12 #include "webrtc/test/gtest.h" 12 #include "webrtc/test/gtest.h"
13 13
14 namespace { 14 namespace {
15 15
16 class RTC_LOCKABLE Lock { 16 class LOCKABLE Lock {
17 public: 17 public:
18 void EnterWrite() const RTC_EXCLUSIVE_LOCK_FUNCTION() {} 18 void EnterWrite() const EXCLUSIVE_LOCK_FUNCTION() {}
19 void EnterRead() const RTC_SHARED_LOCK_FUNCTION() {} 19 void EnterRead() const SHARED_LOCK_FUNCTION() {}
20 bool TryEnterWrite() const RTC_EXCLUSIVE_TRYLOCK_FUNCTION(true) { 20 bool TryEnterWrite() const EXCLUSIVE_TRYLOCK_FUNCTION(true) { return true; }
21 return true; 21 bool TryEnterRead() const SHARED_TRYLOCK_FUNCTION(true) { return true; }
22 } 22 void Leave() const UNLOCK_FUNCTION() {}
23 bool TryEnterRead() const RTC_SHARED_TRYLOCK_FUNCTION(true) { return true; }
24 void Leave() const RTC_UNLOCK_FUNCTION() {}
25 }; 23 };
26 24
27 class RTC_SCOPED_LOCKABLE ScopeLock { 25 class SCOPED_LOCKABLE ScopeLock {
28 public: 26 public:
29 explicit ScopeLock(const Lock& lock) RTC_EXCLUSIVE_LOCK_FUNCTION(lock) {} 27 explicit ScopeLock(const Lock& lock) EXCLUSIVE_LOCK_FUNCTION(lock) {}
30 ~ScopeLock() RTC_UNLOCK_FUNCTION() {} 28 ~ScopeLock() UNLOCK_FUNCTION() {}
31 }; 29 };
32 30
33 class ThreadSafe { 31 class ThreadSafe {
34 public: 32 public:
35 ThreadSafe() { 33 ThreadSafe() {
36 pt_protected_by_lock_ = new int; 34 pt_protected_by_lock_ = new int;
37 pt_protected_by_anything_ = new int; 35 pt_protected_by_anything_ = new int;
38 } 36 }
39 37
40 ~ThreadSafe() { 38 ~ThreadSafe() {
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 unprotected_ = protected_by_lock_; 114 unprotected_ = protected_by_lock_;
117 unprotected_ = *pt_protected_by_lock_; 115 unprotected_ = *pt_protected_by_lock_;
118 } 116 }
119 117
120 void WriteProtectedFunction() EXCLUSIVE_LOCKS_REQUIRED(lock_, pt_lock_) { 118 void WriteProtectedFunction() EXCLUSIVE_LOCKS_REQUIRED(lock_, pt_lock_) {
121 int x = protected_by_lock_; 119 int x = protected_by_lock_;
122 *pt_protected_by_lock_ = x; 120 *pt_protected_by_lock_ = x;
123 protected_by_lock_ = unprotected_; 121 protected_by_lock_ = unprotected_;
124 } 122 }
125 123
126 const Lock& GetLock() RTC_LOCK_RETURNED(lock_) { return lock_; } 124 const Lock& GetLock() LOCK_RETURNED(lock_) { return lock_; }
127 125
128 Lock anylock_ ACQUIRED_BEFORE(lock_); 126 Lock anylock_ ACQUIRED_BEFORE(lock_);
129 Lock lock_; 127 Lock lock_;
130 Lock pt_lock_ ACQUIRED_AFTER(lock_); 128 Lock pt_lock_ ACQUIRED_AFTER(lock_);
131 129
132 int unprotected_ = 0; 130 int unprotected_ = 0;
133 131
134 int protected_by_lock_ GUARDED_BY(lock_) = 0; 132 int protected_by_lock_ GUARDED_BY(lock_) = 0;
135 int protected_by_anything_ RTC_GUARDED_VAR = 0; 133 int protected_by_anything_ GUARDED_VAR = 0;
136 134
137 int* pt_protected_by_lock_ RTC_PT_GUARDED_BY(pt_lock_); 135 int* pt_protected_by_lock_ PT_GUARDED_BY(pt_lock_);
138 int* pt_protected_by_anything_ RTC_PT_GUARDED_VAR; 136 int* pt_protected_by_anything_ PT_GUARDED_VAR;
139 }; 137 };
140 138
141 } // namespace 139 } // namespace
142 140
143 TEST(ThreadAnnotationsTest, Test) { 141 TEST(ThreadAnnotationsTest, Test) {
144 // This test ensure thread annotations doesn't break compilation. 142 // This test ensure thread annotations doesn't break compilation.
145 // Thus no run-time expectations. 143 // Thus no run-time expectations.
146 ThreadSafe t; 144 ThreadSafe t;
147 t.LockInOrder(); 145 t.LockInOrder();
148 t.UnprotectedFunction(); 146 t.UnprotectedFunction();
149 t.ReadProtected(); 147 t.ReadProtected();
150 t.WriteProtected(); 148 t.WriteProtected();
151 t.CallReadProtectedFunction(); 149 t.CallReadProtectedFunction();
152 t.CallWriteProtectedFunction(); 150 t.CallWriteProtectedFunction();
153 } 151 }
OLDNEW
« no previous file with comments | « webrtc/rtc_base/thread_annotations.h ('k') | webrtc/rtc_base/thread_checker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698