Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log2rtp_dump.cc

Issue 3008113002: Remove no- prefix from command line flags in rtc_event_log2text and rtc_event_log2rtp_dump and nega… (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log2rtp_dump.cc
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log2rtp_dump.cc b/webrtc/logging/rtc_event_log/rtc_event_log2rtp_dump.cc
index 4275e5933ffe5e17af6b7705e0e84da6c13791d3..319d1cadf662e322a0f5c34e235f4a8abad9138e 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log2rtp_dump.cc
+++ b/webrtc/logging/rtc_event_log/rtc_event_log2rtp_dump.cc
@@ -27,20 +27,20 @@ namespace {
using MediaType = webrtc::ParsedRtcEventLog::MediaType;
-DEFINE_bool(noaudio,
- false,
+DEFINE_bool(audio,
+ true,
"Excludes audio packets from the converted RTPdump file.");
-DEFINE_bool(novideo,
- false,
+DEFINE_bool(video,
+ true,
"Excludes video packets from the converted RTPdump file.");
-DEFINE_bool(nodata,
- false,
+DEFINE_bool(data,
+ true,
"Excludes data packets from the converted RTPdump file.");
-DEFINE_bool(nortp,
- false,
+DEFINE_bool(rtp,
+ true,
"Excludes RTP packets from the converted RTPdump file.");
-DEFINE_bool(nortcp,
- false,
+DEFINE_bool(rtcp,
+ true,
"Excludes RTCP packets from the converted RTPdump file.");
DEFINE_string(ssrc,
"",
@@ -122,7 +122,7 @@ int main(int argc, char* argv[]) {
// some required fields and we attempt to access them. We could consider
// a softer failure option, but it does not seem useful to generate
// RTP dumps based on broken event logs.
- if (!FLAG_nortp &&
+ if (FLAG_rtp &&
parsed_stream.GetEventType(i) == webrtc::ParsedRtcEventLog::RTP_EVENT) {
webrtc::test::RtpPacket packet;
webrtc::PacketDirection direction;
@@ -143,11 +143,11 @@ int main(int argc, char* argv[]) {
rtp_parser.Parse(&parsed_header);
MediaType media_type =
parsed_stream.GetMediaType(parsed_header.ssrc, direction);
- if (FLAG_noaudio && media_type == MediaType::AUDIO)
+ if (!FLAG_audio && media_type == MediaType::AUDIO)
continue;
- if (FLAG_novideo && media_type == MediaType::VIDEO)
+ if (!FLAG_video && media_type == MediaType::VIDEO)
continue;
- if (FLAG_nodata && media_type == MediaType::DATA)
+ if (!FLAG_data && media_type == MediaType::DATA)
continue;
if (strlen(FLAG_ssrc) > 0) {
const uint32_t packet_ssrc =
@@ -160,7 +160,7 @@ int main(int argc, char* argv[]) {
rtp_writer->WritePacket(&packet);
rtp_counter++;
}
- if (!FLAG_nortcp &&
+ if (FLAG_rtcp &&
parsed_stream.GetEventType(i) ==
webrtc::ParsedRtcEventLog::RTCP_EVENT) {
webrtc::test::RtpPacket packet;
@@ -181,11 +181,11 @@ int main(int argc, char* argv[]) {
const uint32_t packet_ssrc = webrtc::ByteReader<uint32_t>::ReadBigEndian(
reinterpret_cast<const uint8_t*>(packet.data + 4));
MediaType media_type = parsed_stream.GetMediaType(packet_ssrc, direction);
- if (FLAG_noaudio && media_type == MediaType::AUDIO)
+ if (!FLAG_audio && media_type == MediaType::AUDIO)
continue;
- if (FLAG_novideo && media_type == MediaType::VIDEO)
+ if (!FLAG_video && media_type == MediaType::VIDEO)
continue;
- if (FLAG_nodata && media_type == MediaType::DATA)
+ if (!FLAG_data && media_type == MediaType::DATA)
continue;
if (strlen(FLAG_ssrc) > 0) {
if (packet_ssrc != ssrc_filter)
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/rtc_event_log2text.cc » ('j') | webrtc/logging/rtc_event_log/rtc_event_log2text.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698