Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: webrtc/rtc_base/BUILD.gn

Issue 3008103002: Revert of Decoupling rtc_base from Obj-C code (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_base/BUILD.gn
diff --git a/webrtc/rtc_base/BUILD.gn b/webrtc/rtc_base/BUILD.gn
index 743229302b4d7694752ac2f43c1f07f275e668fc..03e8ea608a78c6420eca399840014234c45461e5 100644
--- a/webrtc/rtc_base/BUILD.gn
+++ b/webrtc/rtc_base/BUILD.gn
@@ -429,28 +429,7 @@
}
}
-rtc_source_set("rtc_base") {
- public_deps = [
- ":rtc_base_generic",
- ]
- if (is_ios || is_mac) {
- public_deps += [ ":rtc_base_objc" ]
- }
-}
-
-if (is_ios || is_mac) {
- rtc_source_set("rtc_base_objc") {
- sources = [
- "thread_darwin.mm",
- ]
- deps = [
- ":rtc_base_generic",
- ]
- visibility = [ ":rtc_base" ]
- }
-}
-
-rtc_source_set("rtc_base_generic") {
+rtc_static_library("rtc_base") {
cflags = []
cflags_cc = []
libs = []
@@ -559,11 +538,6 @@
"thread.h",
]
- visibility = [
- ":rtc_base",
- ":rtc_base_objc",
- ]
-
# TODO(henrike): issue 3307, make rtc_base build with the Chromium default
# compiler settings.
suppressed_configs += [ "//build/config/compiler:chromium_code" ]
@@ -623,7 +597,10 @@
}
if (is_ios || is_mac) {
- sources += [ "macifaddrs_converter.cc" ]
+ sources += [
+ "macifaddrs_converter.cc",
+ "thread_darwin.mm",
+ ]
}
if (use_x11) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698