Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 3007473002: Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (Closed)
Patch Set: Response to comments. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 // e.g. because we are already logging or the file cannot be opened. 90 // e.g. because we are already logging or the file cannot be opened.
91 virtual bool StartLogging(const std::string& file_name, 91 virtual bool StartLogging(const std::string& file_name,
92 int64_t max_size_bytes) = 0; 92 int64_t max_size_bytes) = 0;
93 93
94 // Same as above. The RtcEventLog takes ownership of the file if the call 94 // Same as above. The RtcEventLog takes ownership of the file if the call
95 // is successful, i.e. if it returns true. 95 // is successful, i.e. if it returns true.
96 virtual bool StartLogging(rtc::PlatformFile platform_file, 96 virtual bool StartLogging(rtc::PlatformFile platform_file,
97 int64_t max_size_bytes) = 0; 97 int64_t max_size_bytes) = 0;
98 98
99 // Deprecated. Pass an explicit file size limit. 99 // Deprecated. Pass an explicit file size limit.
100 bool StartLogging(const std::string& file_name) { 100 RTC_DEPRECATED bool StartLogging(const std::string& file_name) {
101 return StartLogging(file_name, 10000000); 101 return StartLogging(file_name, 10000000);
102 } 102 }
103 103
104 // Deprecated. Pass an explicit file size limit. 104 // Deprecated. Pass an explicit file size limit.
105 bool StartLogging(rtc::PlatformFile platform_file) { 105 RTC_DEPRECATED bool StartLogging(rtc::PlatformFile platform_file) {
106 return StartLogging(platform_file, 10000000); 106 return StartLogging(platform_file, 10000000);
107 } 107 }
108 108
109 // Stops logging to file and waits until the thread has finished. 109 // Stops logging to file and waits until the thread has finished.
110 virtual void StopLogging() = 0; 110 virtual void StopLogging() = 0;
111 111
112 // Logs configuration information for a video receive stream. 112 // Logs configuration information for a video receive stream.
113 virtual void LogVideoReceiveStreamConfig( 113 virtual void LogVideoReceiveStreamConfig(
114 const rtclog::StreamConfig& config) = 0; 114 const rtclog::StreamConfig& config) = 0;
115 115
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 int min_probes, 222 int min_probes,
223 int min_bytes) override{}; 223 int min_bytes) override{};
224 void LogProbeResultSuccess(int id, int bitrate_bps) override{}; 224 void LogProbeResultSuccess(int id, int bitrate_bps) override{};
225 void LogProbeResultFailure(int id, 225 void LogProbeResultFailure(int id,
226 ProbeFailureReason failure_reason) override{}; 226 ProbeFailureReason failure_reason) override{};
227 }; 227 };
228 228
229 } // namespace webrtc 229 } // namespace webrtc
230 230
231 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 231 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698