Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm

Issue 3007433002: Let CreateVideoDecoder take a cricket::VideoCodec. (Closed)
Patch Set: Remove unrelated change Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm
index 26e73d97001edf2d9df86930d8417e7872c0ce91..499a5e028a99b125b1774e72d1113a85c1031cb2 100644
--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm
+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm
@@ -103,10 +103,8 @@ id<RTCVideoDecoderFactory> ObjCVideoDecoderFactory::wrapped_decoder_factory() co
return decoder_factory_;
}
-VideoDecoder *ObjCVideoDecoderFactory::CreateVideoDecoder(VideoCodecType type) {
- const char *codec_name = CodecTypeToPayloadName(type);
-
- NSString *codecName = [NSString stringWithUTF8String:codec_name];
+VideoDecoder *ObjCVideoDecoderFactory::CreateVideoDecoder(const cricket::VideoCodec &codec) {
+ NSString *codecName = [NSString stringWithUTF8String:codec.name.c_str()];
magjed_webrtc 2017/08/24 08:59:39 I think we could simplify this whole function now
kthelgason 2017/08/24 10:49:47 Sure, we can do that, but that just moves the resp
magjed_webrtc 2017/08/25 15:55:01 I think we should fix the C++ code in core WebRTC
for (RTCVideoCodecInfo *codecInfo in decoder_factory_.supportedCodecs) {
if ([codecName isEqualToString:codecInfo.name]) {
id<RTCVideoDecoder> decoder = [decoder_factory_ createDecoder:codecInfo];

Powered by Google App Engine
This is Rietveld 408576698