webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h - Issue 3007433002: Let CreateVideoDecoder take a cricket::VideoCodec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h

Issue 3007433002: Let CreateVideoDecoder take a cricket::VideoCodec. (Closed)

Patch Set: Remove unrelated change Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/media/engine/webrtcvideoengine.cc ('K') | « webrtc/sdk/BUILD.gn ('k') | webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm » ('j') | webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h

diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h

index dca7fe289981b085f54d433cbf15c58572e1a056..1cb2bb408ba95734894b7d2e5bf21b3de5837fa1 100644

--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h

+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h

@@ -26,7 +26,7 @@ class ObjCVideoDecoderFactory : public cricket::WebRtcVideoDecoderFactory {

id<RTCVideoDecoderFactory> wrapped_decoder_factory() const;

webrtc::VideoDecoder* CreateVideoDecoder(

- webrtc::VideoCodecType type) override;

+ const cricket::VideoCodec& codec) override;

magjed_webrtc 2017/08/24 08:59:39 I think we should add the params here.

kthelgason 2017/08/24 10:49:47 Ack.

void DestroyVideoDecoder(webrtc::VideoDecoder* decoder) override;

private: