Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 3005433002: Fix places that trigger no-unused-lambda-capture (Closed)
Patch Set: Rebased Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index a4d70336030da62f427db29e2aa20aeb7f3c8c5a..f0cbf3e5c58f16bbcf8e7f143ca6fc599c373525 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -4278,9 +4278,13 @@ TEST_F(EndToEndTest, MAYBE_TestFlexfecRtpStatePreservation) {
rtc::CriticalSection crit_;
} observer;
- constexpr int kFrameMaxWidth = 320;
- constexpr int kFrameMaxHeight = 180;
- constexpr int kFrameRate = 15;
+ // These would have been declared as constexpr, but then some compilers
+ // require them to be captured in the lambda, and other compilers complain
+ // about no-ununused-lambda-capture. Keeping them as normal variables was
+ // the easiest work-around.
+ int kFrameMaxWidth = 320;
+ int kFrameMaxHeight = 180;
+ int kFrameRate = 15;
kwiberg-webrtc 2017/08/23 11:35:59 const?
eladalon 2017/08/23 11:42:53 Similarly.
Call::Config config(event_log_.get());

Powered by Google App Engine
This is Rietveld 408576698